Skip to content

chore: Extend agents.toml and .agents/skills (#6637) - #6643

Open
antonis wants to merge 1 commit into
mainfrom
feat/extend-agents-skills
Open

chore: Extend agents.toml and .agents/skills (#6637)#6643
antonis wants to merge 1 commit into
mainfrom
feat/extend-agents-skills

Conversation

@antonis

@antonis antonis commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Extends the agent setup, modeled on sentry-dart:

  • agents.toml — registers the shared getsentry/skills and getsentry/sdk-skills, plus six local path: skills tailored to the RN SDK.
  • .agents/skills/ — six skills forming a pipeline: specdesign-firstcode-guidelines + test-guidelinesdiagnosing-bugs / review. They encode RN-specific knowledge the shared skills can't:
    • code-guidelines (+ references/native-bridge.md) — integrations, the JS↔native bridge, codegen type-vocabulary gotchas, ABI/lockstep rules, usage-tracking via sdk.integrations, and PII gating on sendDefaultPii.
    • review (+ references/smell-baseline.md) — three-axis review (Standards / Spec / Correctness) with the RN SDK threat model.
    • test-guidelines — Jest conventions (naming aligned to packages/core/AGENTS.md).
    • spec, design-first, diagnosing-bugs — the front and debugging halves of the pipeline.
  • Removes the now-redundant .agents/skills/.gitkeep (the directory now has content).

Docs/config only — no SDK runtime code changes.

💡 Motivation and Context

Closes #6637. Brings the RN SDK's agent guidelines and skills in line with sentry-dart, adapted for RN's TypeScript + native-bridge + Jest surfaces.

💚 How did you test it?

Not runtime-testable (Markdown + TOML). Verified:

  • all cited repo paths and cross-skill Markdown links resolve;
  • agents.toml parses and every registered remote skill name exists in getsentry/skills / getsentry/sdk-skills;
  • claims cross-checked against the repo, the SDK dev docs, and docs.sentry.io;
  • no build/test/lint/CI gate reads .agents/** or *.toml.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

Supply-chain / dependency-provenance guidance is added in a stacked follow-up PR on top of this one.

Model the agent setup on sentry-dart: register the shared getsentry/skills
and getsentry/sdk-skills, and add six local path skills tailored to the RN
SDK (spec, design-first, code-guidelines, test-guidelines, diagnosing-bugs,
review). The skills cover the JS/native/bridge threat model, codegen gotchas,
Jest test conventions, and RN-specific usage-tracking and privacy rules.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • chore(deps): update Maestro to v2.10.0 by github-actions in #6641
  • chore(deps): update JavaScript SDK to v10.73.0 by github-actions in #6642
  • test(ios): Speed up sentry-xcode-scripts tests by antonis in #6633
  • fix: Update recommended vscode extensions by antonis in #6640
  • chore(deps): bump actions/setup-java from 5.7.0 to 6.0.0 by dependabot in #6636
  • chore(deps): bump the codeql-action group with 3 updates by dependabot in #6635
  • chore(deps): update JavaScript SDK to v10.72.0 by github-actions in #6634
  • chore(e2e): Bump E2E tests to React Native 0.87.0 by antonis in #6616
  • chore(deps): update CLI to v3.7.0 by github-actions in #6632
  • feat(tracing): Copy app start vitals onto standalone children by buenaflor in #6631
  • chore(deps): update Cocoa SDK to v9.26.1 by github-actions in #6623
  • fix(ios): Force-load the Sentry static archive to keep ObjC category methods by antonis in #6615
  • feat(core): Forward feature flag evaluations to the native SDKs by antonis in #6613
  • chore(deps): update Android SDK to v8.54.0 by github-actions in #6624
  • chore(deps): update Sentry Android Gradle Plugin to v6.20.0 by github-actions in #6627

🤖 This preview updates automatically when you update the PR.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 77a196c

@lucas-zimerman lucas-zimerman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend Warden setup

2 participants