Repository navigation
Add CapabilityUnboundedTuning - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019DnqgLJf7p4sK87dDvktjx
There was a problem hiding this comment.
🟢 Approval recommended
The change is an additive constant with no runtime behavior changes or unresolved findings.
No open issues 🎉
What changed in this PR
Adds CapabilityUnboundedTuning so servers can identify clients that accept Unbounded tuning options before sending them.
Changes:
- Defines the capability string
"unbounded_tuning". - Documents capability gating and forward compatibility through ignoring unknown tuning keys.
- Adds no runtime behavior; advertising and checking the capability remain downstream work.
| File | Description |
|---|---|
types.go |
Adds the capability constant and documents its compatibility contract. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CapabilityUnboundedTuning("unbounded_tuning"). A client advertises it when its Unbounded outbound accepts the newtuningoption: a map of named overrides for pion's ICE, DTLS and SCTP defaults (getlantern/lantern-box#384).Why
sing-box rejects unknown outbound fields, so a client that predates
tuningwould fail to load the whole Unbounded outbound if the server sent it. lantern-cloud needs to know which clients accept it, and capabilities are how it gates optional config.This is the last capability
tuningneeds. lantern-box ignores tuning keys it doesn't recognise, so later knobs can be added on the server alone, and older clients that accept the option simply skip them.Changes
types.go: the constant, documented with that contract, next to the existingCapability*constants.Testing
go build ./...,go vet ./...andgo test ./...: ok.Risk
None: a new constant. Nothing advertises or checks it until radiance and lantern-cloud adopt it.
How to revert
Revert the merge commit, once nothing references the constant.
Pre-PR review (local Codex gate)
CODEX GATE: verdict=approve critical=0 important=0 minor=0 preexisting=0 reviewed=5e8833d7. The review checked the doc comment's contract against lantern-box's tuning parser.approveAGENTS.mdadditions: none🤖 Generated with Claude Code
https://claude.ai/code/session_019DnqgLJf7p4sK87dDvktjx
Summary by CodeRabbit
tuningoption. Servers can use this signal to avoid sending the option to clients that may not recognize it.