Skip to content

Add CapabilityUnboundedTuning - #40

Merged
myleshorton merged 1 commit into
mainfrom
feat/unbounded-tuning-capability
Oct 25, 2026
Merged

myleshorton merged 1 commit into
mainfrom
feat/unbounded-tuning-capability

Conversation

@myleshorton

@myleshorton myleshorton commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Adds CapabilityUnboundedTuning ("unbounded_tuning"). A client advertises it when its Unbounded outbound accepts the new tuning option: a map of named overrides for pion's ICE, DTLS and SCTP defaults (getlantern/lantern-box#384).

Why

sing-box rejects unknown outbound fields, so a client that predates tuning would fail to load the whole Unbounded outbound if the server sent it. lantern-cloud needs to know which clients accept it, and capabilities are how it gates optional config.

This is the last capability tuning needs. lantern-box ignores tuning keys it doesn't recognise, so later knobs can be added on the server alone, and older clients that accept the option simply skip them.

Changes

  • types.go: the constant, documented with that contract, next to the existing Capability* constants.

Testing

  • go build ./..., go vet ./... and go test ./...: ok.

Risk

None: a new constant. Nothing advertises or checks it until radiance and lantern-cloud adopt it.

How to revert

Revert the merge commit, once nothing references the constant.

Pre-PR review (local Codex gate)

  • Rounds: 1 — final: CODEX GATE: verdict=approve critical=0 important=0 minor=0 preexisting=0 reviewed=5
  • Reviewed at: e8833d7. The review checked the doc comment's contract against lantern-box's tuning parser.
  • Exit: approve
  • Step back: not needed
  • Fixed: none
  • Dismissed: none
  • Pre-existing (not introduced here, worth filing): none
  • Proposed AGENTS.md additions: none

🤖 Generated with Claude Code

https://claude.ai/code/session_019DnqgLJf7p4sK87dDvktjx

Summary by CodeRabbit

  • New Features
    • Added client capability signaling for support of the Unbounded outbound’s tuning option. Servers can use this signal to avoid sending the option to clients that may not recognize it.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 16:17
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0718a709-1ed2-4fed-958e-65665a14c8a6
Commits

Reviewing files that changed from the base of the PR and between 2246e49 and e8833d7.

Files selected for processing: 1
  • types.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

This change adds CapabilityUnboundedTuning to the common package. The constant identifies clients that accept the Unbounded outbound’s tuning option.

Changes: Unbounded tuning capability

Layer / File(s) Summary
Declare the tuning capability
types.go
Adds CapabilityUnboundedTuning with the value "unbounded_tuning" and comments describing its use. The comments state that the server sends tuning only to clients that advertise this capability.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: garmr-ulfr

Merge Risk: Minimal · up to e8833

The PR adds a capability constant without changing runtime behavior, so no merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding the CapabilityUnboundedTuning capability.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is an additive constant with no runtime behavior changes or unresolved findings.

No open issues 🎉

What changed in this PR

Adds CapabilityUnboundedTuning so servers can identify clients that accept Unbounded tuning options before sending them.

Changes:

  • Defines the capability string "unbounded_tuning".
  • Documents capability gating and forward compatibility through ignoring unknown tuning keys.
  • Adds no runtime behavior; advertising and checking the capability remain downstream work.
File Description
types.go Adds the capability constant and documents its compatibility contract.

Review effort: Balanced

@myleshorton
myleshorton merged commit 9182c99 into main Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants