Skip to content

Bump lantern-box to v0.0.174 and advertise Unbounded tuning - #707

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-lantern-box-unbounded-tuning
Oct 25, 2026
Merged

myleshorton merged 1 commit into
mainfrom
fisk/bump-lantern-box-unbounded-tuning

Conversation

@myleshorton

@myleshorton myleshorton commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Bumps lantern-box to v0.0.174, which upgrades the Unbounded outbound to the latest pion and adds a tuning option (getlantern/lantern-box#384). Advertises CapabilityUnboundedTuning so the server can send that option to this client.

Why

About 27% of Unbounded attempts reach "ICE connected" and then stall in the DTLS handshake. Our consumer is the DTLS server, and the pion dtls fixes for lost server flights took rtcprobe runs at 20% UDP loss from 16/26 to 27/30 connections (getlantern/unbounded#478). This bump is what puts that fix in front of users.

Changes

  • go.mod / go.sum:
    • lantern-box v0.0.169 → v0.0.174
    • common → 9182c99, which adds CapabilityUnboundedTuning (Add CapabilityUnboundedTuning common#40)
    • broflake → ae5d221, pulled in by lantern-box
    • pion: webrtc v4.2.25, ice v4.4.8, dtls v3.1.15, sctp v1.12.0. transport/stun/turn move from v4 to v5.
    • go mod tidy run.
  • config/fetcher.go: adds CapabilityUnboundedTuning to the config request's capabilities.
  • config/fetcher_test.go: asserts the capability is advertised.

Also in this lantern-box range

The bump also brings in these client-side changes since v0.0.169:

#381 and #382 change only Tencent image builds.

Testing

  • go test -tags with_clash_api on every package except cmd/lantern: passes. cmd/lantern needs the standalone tag and fails to build without it on main too.
  • Builds: cmd/lantern with standalone, and cmd/lanternd with the Makefile's tags.
  • Not tested: a live Unbounded connection from radiance. lantern-box's tuning tests and broflake's TestTunedPeersConnect cover the new code paths.

Risk

Medium: a pion upgrade across ICE, DTLS and SCTP for every Unbounded connection, plus the mutableautoselect changes above. Advertising the capability changes nothing on its own. It only lets the server start sending tuning.

How to revert

Revert this PR. A reverted build stops advertising the capability, so the server stops sending it tuning. Builds already shipped with this PR keep advertising it, which is correct, since they accept the option.

Pre-PR review (local Codex gate)

  • Rounds: 1 — final: CODEX GATE: verdict=approve critical=0 important=0 minor=0 preexisting=0 reviewed=49
  • Reviewed at: fdd551a. Coverage included broflake's clientcore and tuning code, lantern-box's unbounded outbound and mutableautoselect at both versions, common's capability constants, and pion's setting engine.
  • Exit: approve
  • Step back: not needed
  • Fixed: none
  • Dismissed: none
  • Pre-existing (not introduced here, worth filing): unbounded/unbounded_test.go:72,96 — go vet copylocks: the tests copy a sync.Once (found by go vet, not the gate)
  • Proposed AGENTS.md additions: none

🤖 Generated with Claude Code

https://claude.ai/code/session_017Auq9rzNksZsxJYbVVZu4m

Summary by CodeRabbit

  • New Features
    • Configuration requests now advertise support for unbounded tuning, allowing compatible services to account for this capability when providing configuration. The existing advertisement of non-selectable outbounds is retained.

lantern-box v0.0.174 upgrades the Unbounded outbound to the latest pion
(dtls v3.1.15, ice v4.4.8, sctp v1.12.0, webrtc v4.2.25) and adds a
"tuning" option for server-side pion overrides. Advertise
CapabilityUnboundedTuning, from the bumped common, so the server can send
that option to this client.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Auq9rzNksZsxJYbVVZu4m
Copilot AI balanced review requested due to automatic review settings October 25, 2026 06:22
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b1eaba0-0609-4ce6-897d-f7b37d5dfe91
Commits

Reviewing files that changed from the base of the PR and between 31433fe and fdd551a.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 3
  • config/fetcher.go
  • config/fetcher_test.go
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The configuration request now advertises CapabilityUnboundedTuning alongside CapabilityNonSelectableOutbounds. The test checks for the added capability. The module requirements for several dependencies are also updated.

Changes: Configuration Capability

Layer / File(s) Summary
Advertise unbounded tuning
config/fetcher.go, config/fetcher_test.go
The configuration request includes CapabilityUnboundedTuning. TestFetchConfig checks that the request includes it.

Dependency Updates

Layer / File(s) Summary
Update module requirements
go.mod
Required versions of broflake, common, lantern-box, and Pion dependencies are updated. The stun, transport, and turn dependencies move to newer major versions.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: garmr-ulfr, jigar-f

Merge Risk: Minimal · up to fdd55

The capability advertisement, dependency requirements, and associated test change present no identified merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies both primary changes: upgrading lantern-box to v0.0.174 and advertising Unbounded tuning capability.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The transport and automatic-selection upgrades warrant human review because live Unbounded operation through Radiance remains unvalidated.

No open issues 🎉

What changed in this PR

Updates Radiance’s Unbounded transport dependencies to deliver DTLS handshake reliability fixes and enable server-provided tuning.

Changes:

  • Upgrades lantern-box to v0.0.174 and updates common, broflake, and Pion dependencies.
  • Advertises CapabilityUnboundedTuning in configuration requests.
  • Adds a regression assertion for the new capability.
File Description
go.sum Updates checksums for the upgraded dependency graph.
go.mod Pins lantern-box and related transport dependencies.
config/​fetcher.go Advertises support for Unbounded tuning.
config/​fetcher_test.go Verifies configuration requests include the tuning capability.

Review effort: Balanced

@myleshorton
myleshorton merged commit 8c9bd6e into main Oct 25, 2026
6 checks passed
@myleshorton
myleshorton deleted the fisk/bump-lantern-box-unbounded-tuning branch October 25, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants