Repository navigation
Bump lantern-box to v0.0.174 and advertise Unbounded tuning - #707
Merged
Merged
Conversation
lantern-box v0.0.174 upgrades the Unbounded outbound to the latest pion (dtls v3.1.15, ice v4.4.8, sctp v1.12.0, webrtc v4.2.25) and adds a "tuning" option for server-side pion overrides. Advertise CapabilityUnboundedTuning, from the bumped common, so the server can send that option to this client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Auq9rzNksZsxJYbVVZu4m
Contributor
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The transport and automatic-selection upgrades warrant human review because live Unbounded operation through Radiance remains unvalidated.
No open issues 🎉
What changed in this PR
Updates Radiance’s Unbounded transport dependencies to deliver DTLS handshake reliability fixes and enable server-provided tuning.
Changes:
- Upgrades lantern-box to v0.0.174 and updates common, broflake, and Pion dependencies.
- Advertises
CapabilityUnboundedTuningin configuration requests. - Adds a regression assertion for the new capability.
| File | Description |
|---|---|
go.sum |
Updates checksums for the upgraded dependency graph. |
go.mod |
Pins lantern-box and related transport dependencies. |
config/fetcher.go |
Advertises support for Unbounded tuning. |
config/fetcher_test.go |
Verifies configuration requests include the tuning capability. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps lantern-box to v0.0.174, which upgrades the Unbounded outbound to the latest pion and adds a
tuningoption (getlantern/lantern-box#384). AdvertisesCapabilityUnboundedTuningso the server can send that option to this client.Why
About 27% of Unbounded attempts reach "ICE connected" and then stall in the DTLS handshake. Our consumer is the DTLS server, and the pion dtls fixes for lost server flights took
rtcproberuns at 20% UDP loss from 16/26 to 27/30 connections (getlantern/unbounded#478). This bump is what puts that fix in front of users.Changes
go.mod/go.sum:9182c99, which addsCapabilityUnboundedTuning(Add CapabilityUnboundedTuning common#40)ae5d221, pulled in by lantern-boxgo mod tidyrun.config/fetcher.go: addsCapabilityUnboundedTuningto the config request's capabilities.config/fetcher_test.go: asserts the capability is advertised.Also in this lantern-box range
The bump also brings in these client-side changes since v0.0.169:
#381 and #382 change only Tencent image builds.
Testing
go test -tags with_clash_apion every package exceptcmd/lantern: passes.cmd/lanternneeds thestandalonetag and fails to build without it onmaintoo.cmd/lanternwithstandalone, andcmd/lanterndwith the Makefile's tags.TestTunedPeersConnectcover the new code paths.Risk
Medium: a pion upgrade across ICE, DTLS and SCTP for every Unbounded connection, plus the mutableautoselect changes above. Advertising the capability changes nothing on its own. It only lets the server start sending
tuning.How to revert
Revert this PR. A reverted build stops advertising the capability, so the server stops sending it
tuning. Builds already shipped with this PR keep advertising it, which is correct, since they accept the option.Pre-PR review (local Codex gate)
CODEX GATE: verdict=approve critical=0 important=0 minor=0 preexisting=0 reviewed=49fdd551a. Coverage included broflake's clientcore and tuning code, lantern-box's unbounded outbound and mutableautoselect at both versions, common's capability constants, and pion's setting engine.approveunbounded/unbounded_test.go:72,96—go vetcopylocks: the tests copy async.Once(found bygo vet, not the gate)AGENTS.mdadditions: none🤖 Generated with Claude Code
https://claude.ai/code/session_017Auq9rzNksZsxJYbVVZu4m
Summary by CodeRabbit