Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
forntoh
commented
Oct 22, 2026
forntoh
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed commit 2dbf41f and the recorded validation evidence; no blocking findings in this test-only change.
- The two tests exercise menu commands and rendered character cells for short, boundary-length, and overflowing labels; they cover value growth, ITEM_RANGE_REF cancellation, and the neighboring row.
- The recorded reproduction fails on 5.12.1 and passes with the existing correction in #423, included in 5.13.0. #397 has now been closed with an explanation of that available fix.
- GitHub Arduino CI and spell-check are successful at this head. Engineering evidence records seven passing host suites and Uno/ESP32-S3 compile checks. Physical LCD behavior, Wokwi execution, and the full example/board matrix remain unverified.
The regression coverage is suitable for maintainer review. The PR remains a draft; merging is a separate maintainer decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protect the long-label range-edit behavior reported in #397, already corrected by #423. This adds character-cell regression tests; library code and public APIs are unchanged.
Evidence
12345678901234, the row is<12345678901234, shift 0, and the cursor covers the label.After: Both pass on master 52e10ed (46 assertions). The row is
<5678901234:99%, shift 4, with the cursor on the final digit. The existing fix is e311e03 (Add graphical display support聽#423), included in tag 5.13.0.IntFloatValuesand a separate long-labelITEM_RANGE/ITEM_RANGE_REFfixture on Arduino Uno and ESP32-S3 DevKitC-1.clang-format --dry-run --Werror test/CharacterDisplayRenderer.cppandgit diff --checkpass.Merge Danger
Door: Two-way
Blast Radius: Tests
Only a new unit-test translation unit is added. No issue-closing keyword is used; issue disposition is a separate decision.