Repository navigation
ci: bump action and tool pins, add Lua 5.5 to the test matrix - #17
Merged
Merged
Conversation
action-gh-release v1 runs on the retired Node 16 runtime, which put the release job at risk; the other actions were one or more majors behind.
Contributor
There was a problem hiding this comment.
Looks good. CI is green at 1df8393 across all 12 checks. The new Lua 5.5 leg really runs a 5.5 interpreter (Lua 5.5.0 banner in the job log, every suite passing), and Build Combined Module covers the upload-artifact@v7 step.
The release job won't run until the next tag, so I checked it by hand: softprops/action-gh-release@v3 is node24 and still declares every input release.yml passes (draft, prerelease, name, tag_name, generate_release_notes, files). permissions: contents: write is already set.
Two optional follow-ups, neither blocking:
src/crypto/init.lua:6: the module doc still says "Runs on Lua 5.1, 5.2, 5.3, 5.4, and LuaJIT". It now disagrees with the README line this PR updates.run_tests_matrix.shstill lists only 5.1.5 to 5.4.8 plus LuaJIT, somake test-matrixdoesn't cover 5.5 locally. CLAUDE.md:327 ("across Lua 5.1–5.4 + LuaJIT") is accurate for that script as it stands. If you want local parity, add a 5.5 entry there and update that line too.
This was referenced Oct 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps every stale CI pin to the current upstream release (checked 2026-10-17) and adds Lua 5.5 to the test matrix. The highest-priority bump is
softprops/action-gh-releasev1, which runs on Node 16. GitHub has retired that runtime, so the release job was at risk.softprops/action-gh-release(release.yml)tag_name: ${{ github.ref }}is still stripped ofrefs/tags/(normalizeTagName). Since v2.5.0 the release is created as a draft and published once all assets are uploaded, so a failed upload leaves a draft instead of a half-populated release.actions/checkoutpull_request_target/workflow_run, which we don't use. None of this affects us.actions/upload-artifactarchive: false. The default stays zipped, so thecrypto.luaartifact is unchanged.leafo/gh-actions-lua5.5the defaultluaVersion, but every job here setsluaVersionexplicitly. The5.4alias now resolves to 5.4.8 and5.5to 5.5.0.leafo/gh-actions-luarocksJohnnyMorganz/stylua-actionargs: false(install without running) is still supported.make format-checkunder 2.6.0 reports no diffs, sosrc/is unchanged.make typecheck: no problems found.5.5bitnincluded. In CI the5.5alias builds 5.5.0.CLAUDE.md (the LuaLS pin and the CI test-matrix line) and README's supported-versions line are updated to match.
Left alone because they are already current: the lua-openssl rocks (0.11.1-1 is the newest), vendored bitn (v0.6.4) and the
ubuntu-26.04runners.Test plan
make checkpasses locally with StyLua 2.6.0 and lua-language-server 3.19.2make testpasses (LuaJIT 2.1)LUA_BINARY=lua5.5 ./run_tests.shpasses (Lua 5.5.1, 16/16)ubuntu-26.04, and SC2193 fires on the existingluajit*glob testv*tag