Repository navigation
ci: bump action and tool pins, add Lua 5.5 to the test matrix - #37
Merged
Merged
Conversation
action-gh-release v1 runs on the retired Node 16 runtime, which put the release job at risk; the other actions were one or more majors behind.
Contributor
There was a problem hiding this comment.
Reviewed at 3004a65. All 9 checks green. The new Lua 5.5 leg built 5.5.0 and ran the full suite (812 PASS, 0 FAIL), and Check ran StyLua v2.6.0 and lua-language-server 3.19.2 with "no problems found". Locally, ./run_tests.sh all also passes under Lua 5.5.0 and LuaJIT 2.1.
release.yml: every input passed to softprops/action-gh-release@v3 (draft, prerelease, name, tag_name, generate_release_notes, files) still exists in v3. That job only runs on a v* tag, so the first real test is the next release.
Docs match the workflow. CLAUDE.md now says outright that the local test-matrix doesn't cover 5.5, which is better than the twin PRs, where run_tests_matrix.sh silently lacks it.
Non-blocking:
vendor/bitn.luadocstrings still say "5.1, 5.2, 5.3, 5.4, and LuaJIT". That's vendored text, so it gets fixed upstream in lua-bitn and comes in on the next vendor sync, not here.- The body has no YouTrack reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps every stale CI pin to the current upstream release (checked 2026-10-17) and adds Lua 5.5 to the test matrix. This is the same change as finitelabs/lua-crypto#17, finitelabs/lua-bitn#25, finitelabs/lua-bthome-ble#19 and finitelabs/lua-noiseprotocol#30. The highest-priority bump is
softprops/action-gh-releasev1, which runs on Node 16. GitHub has retired that runtime, so the release job was at risk.softprops/action-gh-release(release.yml)tag_name: ${{ github.ref }}is still stripped ofrefs/tags/(normalizeTagName). Since v2.5.0 the release is created as a draft and published once all assets are uploaded.actions/checkoutpull_request_target/workflow_run, which we don't use. None of this affects us.actions/upload-artifactarchive: false. The default stays zipped, so the artifact is unchanged.leafo/gh-actions-lua5.5the defaultluaVersion, but every job here setsluaVersionexplicitly. The5.4alias now resolves to 5.4.8 and5.5to 5.5.0.leafo/gh-actions-luarocksJohnnyMorganz/stylua-actionargs: false(install without running) is still supported.actions/setup-python(check job)pip-installinput, which we don't use.python-version: '3.12'is unchanged.5.5./run_tests.sh allpasses 8/8 under a local Lua 5.5.1 with no source changes. In CI the5.5alias builds 5.5.0. Theluajit-2.1→luajit-openrestymapping is untouched and still in gh-actions-lua v13'sLUAJIT_REPOS.Under StyLua 2.6.0
make format-checkreports no diffs, and under lua-language-server 3.19.2make typecheckfinds no problems.check-provenance,check-types,check-schema,check-wire-vectorsandcheck-float-vectorsall pass too. Sosrc/andtypes.luaare unchanged.CLAUDE.md (the LuaLS pin, the "3.18.2 and 3.19.0 agree" note, now including 3.19.2, the CI test-matrix line, and the note that CI covers more than the local luaenv matrix) and README's supported-versions line are updated to match.
Test plan
make checkpasses locally with StyLua 2.6.0, lua-language-server 3.19.2, and a fresh.venvfromtools/requirements.txt(protobuf 4.25.9, matching CI)make check-wire-vectorsandmake check-float-vectorspassmake test-allpasses under LuaJIT 2.1 (8/8)LUA_BINARY=lua5.5 ./run_tests.sh allpasses (Lua 5.5.1, 8/8)v*tag