Skip to content

chore(webhook): bump local-webhook pin 0.32.0 -> 0.34.1 (per-object batches, #887) #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionello merged 3 commits into from
Oct 23, 2026
Merged

chore(webhook): bump local-webhook pin 0.32.0 -> 0.34.1 (per-object batches, #887) #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f42a22
chore(webhook): bump local-webhook pin 0.32.0 -> 0.34.0
defangdevs Oct 23, 2026
aa9bc1d
tests(webhook): give each re-processed delivery its own id
defangdevs Oct 23, 2026
0d1a9c5
chore(webhook): pin local-webhook 0.34.1
defangdevs Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/agent-box.nix
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions nix/webhook-pin.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
# module-generated-up-to-date check fails until it matches.
{
repo = "defangdevs/local-channels";
rev = "2be2185cbc196aaaa88cef1d9da0292d94ba7243";
sha256 = "sha256-N95IhtnjXXqt5WB5wq0pISAsXwxmAFLI/zafl/J4aPU=";
rev = "17c457ac57258c5a8b96c667eedaec95ad8c35e8";
sha256 = "sha256-JH5ouvviN2UWRS89bGn1aUXUIwtUAQ6uPo1xX8nQCD8=";
}
10 changes: 7 additions & 3 deletions tests/webhook.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,10 @@
" -H 'content-type: application/json' -H 'x-github-event: workflow_run'"
" -H 'x-github-delivery: test-1' --data-binary @/tmp/body.json"
)
# 0.33.0 drops a re-sent delivery id, so a later post that must be
# processed again needs an id of its own.
ids = iter(range(100))
fresh = lambda: post.replace("test-1", "test-1-%d" % next(ids)) # noqa: E731
# Wrong signature and no signature are both refused, before any parsing.
client.succeed(
f"{post} -H 'x-hub-signature-256: sha256=00' "
Expand Down Expand Up @@ -617,7 +621,7 @@
# sessions on one PR. The suppression is logged, because a silently skipped
# spawn is indistinguishable from a watch that stopped working (#170).
client.succeed(
f"{post} -H 'x-hub-signature-256: sha256={sig}' "
f"{fresh()} -H 'x-hub-signature-256: sha256={sig}' "
f"https://box.test/agent/webhook/github | grep -x 200"
)
machine.wait_until_succeeds(
Expand Down Expand Up @@ -693,7 +697,7 @@
# restarting it afterwards proves the spawn + consumption half.
machine.succeed("systemctl stop agent-box@agent.service")
client.succeed(
f"{post} -H 'x-hub-signature-256: sha256={sig}' "
f"{fresh()} -H 'x-hub-signature-256: sha256={sig}' "
f"https://box.test/agent/webhook/github | grep -x 200"
)
machine.wait_until_succeeds(
Expand Down Expand Up @@ -865,7 +869,7 @@
timeout=30,
)
client.succeed(
f"{post} -H 'x-hub-signature-256: sha256={sig}' "
f"{fresh()} -H 'x-hub-signature-256: sha256={sig}' "
f"https://box.test/agent/webhook/github | grep -x 200"
)
# The named suppression is the primary evidence: had the brake missed, the
Expand Down
Loading