Repository navigation
Add audio kind (music / speech / sound effect) and skip transcribing music - #49
Merged
Merged
Conversation
…music Uploads of music no longer go to Deepgram, while voice recordings still do. audio_kind on audio assets, NULL when not known: - Set at upload from tags (a speech genre means speech; any other genre or a BPM means music), by a music page import (always music), or by hand in the Music tab. Never guessed from the sound. - Transcription is skipped only for music and sound effects; unknown is transcribed exactly as before. Music analysis skips speech and sfx. - Changing it catches up: speech transcribes an untranscribed file, music measures it. The Transcribe button still works on any kind. - A duplicate found by checksum on page import gains kind "music" if blank. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCL4jm6ogZBBhnjEfBBaXU
davior
pushed a commit
to davior/gvc
that referenced
this pull request
Oct 26, 2026
GAM now records what an audio file is (davior/gam#49). GVC reads it: - GamAssetRead.audio_kind: music, speech or sfx; null when not known or against a GAM without it, and for any value GVC does not recognise. - search_assets and get_asset include it as "kind", and the prompt says to use music (or a plainly musical unknown) for a soundtrack, never speech, with sfx for sound effects. - The Sound picker leads its summary line with "Speech" or "Sound effect", so a voice memo stands out in a list of tracks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCL4jm6ogZBBhnjEfBBaXU
davior
marked this pull request as ready for review
October 26, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every audio upload was sent to Deepgram when a key was configured, so music was billed per minute and transcribed to nothing. Voice recordings still need their transcripts, so this PR adds a label saying what an audio file is, and transcription follows that label.
audio_kindon audio assetsmusic,speech,sfx, or NULL for not known. One nullable column; existing rows stay NULL.audio_kind="music"toingest_fileso the kind is on the row before that decision.not_audio.musicif that copy has no kind yet.A follow-up in gvc will let Video Creator prefer
musicand skipspeechwhen choosing a soundtrack.Testing
pytest -q: 1385 passed. The newtests/test_audio_kind.pycovers:npm run format:check,npm run lint,npm test(426 passed) andnpm run buildall clean.Generated by Claude Code