Repository navigation
Tell music from voice recordings when choosing a soundtrack - #22
Merged
Merged
Conversation
GAM now records what an audio file is (davior/gam#49). GVC reads it: - GamAssetRead.audio_kind: music, speech or sfx; null when not known or against a GAM without it, and for any value GVC does not recognise. - search_assets and get_asset include it as "kind", and the prompt says to use music (or a plainly musical unknown) for a soundtrack, never speech, with sfx for sound effects. - The Sound picker leads its summary line with "Speech" or "Sound effect", so a voice memo stands out in a list of tracks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCL4jm6ogZBBhnjEfBBaXU
davior
marked this pull request as ready for review
October 26, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAM now records what an audio file is:
music,speechorsfx(davior/gam#49). With this PR, GVC uses that to stop a voice memo being picked as a soundtrack.Changes
GamAssetRead.audio_kindis mapped from GAM. It isnullwhen GAM doesn't know the kind, when GAM predates gam#49, or when the value isn't one GVC recognises, so this works against any GAM version."kind"insearch_assetsandget_assetresults. The prompt now says:musicfor a soundtrack, or an unknown file whose name and music profile make it plainly a track;speechfor a soundtrack;sfxfor sound effects andspeechfor extra voice.audioSummaryinapi/gam.ts), so a voice memo stands out in a list of tracks.docs/plan-of-attack.mdrecords the dependency as GAM-7.Testing
pytest -q: 706 passed. New tests cover the client mapping (known kinds, an older GAM, an unrecognised value) and the assistant output.npm run format:check,npm run lint,npm test(186 passed) andnpm run buildall clean.Generated by Claude Code