Issue/589 invalid references via batch bundle

[hhund]

To run reference checks in transaction bundles a special CheckReferencesCommand was used previously. This command allows execution of the checks for all create and update operations on the final DB state. But this design requires a complicated error handling implementation, since two command objects existing for every POST (create) or PUT (update) entry in the bundle. The error handling implementation of batch bundles was incomplete, resulting a reference check bypass.

With this PR the batch/transaction Bundle execution implementation was refactored to remove the CheckReferencesCommand and introduce a new checkReferences execution phase. For a batch bundles the checkReferences phase is executed together with the execute phase for every Command. While transaction bundles first run all execute phases for all commands before running the checkReferences phase.

Other changes:

• Additional integration tests
• Disabled disabled twitter-broker and identity-brokering-api features in dev setup keycloak.
• Added missing javaagent config for surefire tests in the ‎dsf-bpe-process-api-v2-impl module.

fixes #589

[schwzr]

Now non-unique references fail with a 500 error:

package dev.dsf.fhir.integration;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;

import java.util.UUID;

import org.hl7.fhir.r4.model.Bundle;
import org.hl7.fhir.r4.model.Bundle.BundleType;
import org.hl7.fhir.r4.model.Bundle.HTTPVerb;
import org.hl7.fhir.r4.model.Patient;
import org.junit.Test;

import dev.dsf.fhir.dao.PatientDao;
import jakarta.ws.rs.WebApplicationException;

public class Pr590PathsIntegrationTest extends AbstractIntegrationTest
{
    @Test
    public void batchConditionalCreateMultipleMatches() throws Exception
    {
        // Two existing resources match the conditional create criteria.
        PatientDao dao = getSpringWebApplicationContext().getBean(PatientDao.class);
        for (int i = 0; i < 2; i++)
        {
            Patient patient = new Patient();
            patient.addIdentifier().setSystem("urn:pr590:test").setValue("duplicate");
            dao.create(patient);
        }

        Bundle request = new Bundle().setType(BundleType.BATCH);
        request.addEntry().setFullUrl("urn:uuid:" + UUID.randomUUID())
            .setResource(new Patient().setActive(true)).getRequest()
            .setMethod(HTTPVerb.POST).setUrl("Patient")
            .setIfNoneExist("identifier=urn:pr590:test|duplicate");

        Bundle result = null;
        int actualHttpStatus = 200;
        String failureMessage = "Expected HTTP 200 with a batch-response entry containing 412 Precondition Failed";
        try
        {
            result = getWebserviceClient().postBundle(request);
        }
        catch (WebApplicationException e)
        {
            actualHttpStatus = e.getResponse().getStatus();
            failureMessage += "; actual error: " + e.getMessage();
        }

        assertEquals(failureMessage, 200, actualHttpStatus);
        assertNotNull(result);
        assertEquals(BundleType.BATCHRESPONSE, result.getType());
        assertEquals(1, result.getEntry().size());
        assertEquals("412 Precondition Failed", result.getEntryFirstRep().getResponse().getStatus());
    }
}

-------------------------------------------------------------------------------
Test set: dev.dsf.fhir.integration.Pr590PathsIntegrationTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.52 s <<< FAILURE! -- in dev.dsf.fhir.integration.Pr590PathsIntegrationTest
dev.dsf.fhir.integration.Pr590PathsIntegrationTest.batchConditionalCreateMultipleMatches -- Time elapsed: 0.272 s <<< FAILURE!
java.lang.AssertionError: Expected HTTP 200 with a batch-response entry containing 412 Precondition Failed; actual error: ERROR EXCEPTION Error while executing transaction bundle expected:<200> but was:<500>

[hhund]

Now non-unique references fail with a 500 error:
...

New tests added via fff5c46, fix in 676e37c (+ code formatting f304056)