chore(core): remove unused extractJsBlocks to resolve CodeQL ReDoS alert - #2340
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mbiernacik
force-pushed
the
remove-unused-extract-js-blocks
branch
from
September 23, 2026 10:39
4c79ff7 to
bffb2a7
Compare
rafal-hawrylak
requested changes
Sep 24, 2026
mbiernacik
force-pushed
the
remove-unused-extract-js-blocks
branch
from
September 24, 2026 14:11
bffb2a7 to
8db4ab6
Compare
rafal-hawrylak
self-requested a review
September 24, 2026 18:43
rafal-hawrylak
approved these changes
Sep 24, 2026
mbiernacik
force-pushed
the
remove-unused-extract-js-blocks
branch
from
September 25, 2026 08:30
8db4ab6 to
c559217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves CodeQL alerts #10 and #11 (
js/redos, CWE-1333): Inefficient regular expression leading to exponential backtracking inextractJsBlocks.Details
extractJsBlockswas previously used only by legacy.sqlcompilation functions (compileTableSql,compileOperationSql,compileAssertionSql), which were removed in PR Deprecate support for old type.sqlfiles #1564 (7c264505).core/index.ts/@dataform/core, and is not referenced anywhere in the repository.