Sqlx comment parsing backslashes - #2339
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mbiernacik
reviewed
Sep 23, 2026
| return code; | ||
| } | ||
|
|
||
| export function extractJsBlocks(code: string): { sql: string; js: string } { |
rafal-hawrylak
requested changes
Sep 24, 2026
Ford544
force-pushed
the
sqlx-comment-parsing-backslashes
branch
from
September 24, 2026 14:34
a9f9daa to
fa3a484
Compare
rafal-hawrylak
self-requested a review
September 24, 2026 18:42
rafal-hawrylak
approved these changes
Sep 24, 2026
Ford544
force-pushed
the
sqlx-comment-parsing-backslashes
branch
from
September 25, 2026 06:33
fa3a484 to
efe7314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape backslashes in sql comments in sqlx files.
Currently, the compiler escapes backticks (`) and dollar signs ($) in sql comments to prevent them from being interpreted as the end of string/JS block by the JS runtime. However, these symbols can still remain unescaped if they are preceded by a backslash in the user code, for example:
-- \`
after escaping becomes:
-- \\`
the backslash is escaped and the backtick remains unescaped, which is likely to trigger a SyntaxError
With this change, all backslashes are escaped, so the result would instead be:
-- \\\`
with the backtick still escaped.
Additionally, tests were added covering this behavior.