Skip to content

test(locallibrary): declare the sizes option the export overflow test passes #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
botandbang merged 1 commit into from
Oct 31, 2026
Merged

test(locallibrary): declare the sizes option the export overflow test passes #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/locallibrary/tests/it/plugins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,10 @@ impl Fixture {
}

/// The echo plugin, its exporter declaring the test plugin's own options: `outside`, a file
/// it says it writes in place of the export, and `extra`, one it writes besides.
/// it says it writes in place of the export, `extra`, one it writes besides, and `sizes`, the
/// sizes of the files it says it writes.
fn exporting() -> Fixture {
let options = "options = { type = \"object\", properties = { extra = { type = \"string\" }, outside = { type = \"string\" } } }";
let options = "options = { type = \"object\", properties = { extra = { type = \"string\" }, outside = { type = \"string\" }, sizes = { type = \"array\", items = { type = \"integer\" } } } }";
let manifest = ECHO.replace("extension = \"m3u\"\n", &format!("extension = \"m3u\"\n{options}\n"));
assert_ne!(manifest, ECHO);
Fixture::new(|dir| vec![spec(dir, &manifest, &[])], Options::default())
Expand Down
2 changes: 1 addition & 1 deletion crates/locallibrary/tests/it/plugins/exports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ fn an_export_writes_out_only_what_its_exporter_says(tc: hegel::TestCase) {
#[hegel::test(test_cases = 20, suppress_health_check = [hegel::HealthCheck::TooSlow])]
fn an_exports_sizes_that_overflow_are_refused(tc: hegel::TestCase) {
use hegel::generators as gs;
let f = Fixture::echo();
let f = Fixture::exporting();
let size = hegel::one_of!(gs::integers::<u64>().min_value(u64::MAX - 1000), gs::integers::<u64>().max_value(1000));
let sizes: Vec<u64> = tc.draw(gs::vecs(size).min_size(1).max_size(4));
let out = f._dir.path().join("out");
Expand Down
Loading