Repository navigation
test(locallibrary): declare the sizes option the export overflow test passes - #348
Merged
Merged
Conversation
github-actions
Bot
added
locallibrary
botandbang
enabled auto-merge
October 31, 2026 15:27
bnb
approved these changes
Oct 31, 2026
Rust coverageFrom run 674. Both are held to the thresholds in .cargo/config.toml.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an_exports_sizes_that_overflow_are_refused(added in #304) fails on main with "this format has no options, not even "sizes"". #304's test passes the test plugin asizesoption on the echo plugin's m3u exporter, which declares no options, and #313 made the host refuse options a format doesn't declare. Each PR passed CI on its own; together on main the test fails every run.Changed:
exporting()fixture intests/it/plugins.rs, which declares the test plugin's own export options, also declaressizes(an array of integers).Fixture::exporting()in place ofFixture::echo().Nothing in the host changes. The test fails on main f7f7277 and passes with this (5 of 5 runs), along with the 204 plugin tests and clippy.