Repository navigation
Comeback alarm: no alarm for a fix done another way, and name the right commit - #116
Merged
Merged
Conversation
…ht commit Checked against the last 300 commits of the 19 scoreboard projects. The alarm fired 13 times; 6 were fixes a later commit did another way (marshmallow, more-itertools, serde_json, indexmap x2) or tidy-ups (bytes), 2 were reverts coming back (click, JSON-java), and on testify it named a merge instead of the commit that put the old code back. - A later commit that took the fix's lines out but wrote its own code for the same thing in the same function is a rewrite, not an undo: no alarm. - A checked commit that is itself a revert, or a tidy-up, gets no alarm. - The culprit is the newest commit where the fix went missing, not a merge that brought in a branch that still had it. Assisted-by: Claude Code
Contributor
|
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by CH · project thread
What was wrong, what you changed, how you checked:
I ran v0.11.0's comeback alarm over the last 300 commits of each of the 19 scoreboard projects. It only reads git history and runs no tests. It fired "UNDONE BY A LATER COMMIT" 13 times, and I checked each one by hand:
--last 40) named the merge "Merge pull request #1935 … yaml-update". The commit that actually put the old code back is 15f6826.Changes in
came_back:python -m pytestpasses: 172 passed. The try-to-trick-Bite harness didn't get worse: 29 ok vs 28 in the last saved run.Assisted-by: Claude Code
Generated by Claude Code