Repository navigation
Take ClientNot from the core library, with the per-language parts in a NotebookConfig - #9
Merged
Merged
Conversation
thomasjm
force-pushed
the
client-not-config
branch
from
October 12, 2026 03:00
8719796 to
4a31ac6
Compare
thomasjm
force-pushed
the
client-not-config
branch
from
October 12, 2026 03:18
4a31ac6 to
6a90253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last of the Transform modules to move into notebook-language-server-core. The six things that differ per language (transformer params, where the shadow document goes, how to name an unopened document, what to do when the open set changes, the language name) move into a
NotebookConfigrecord, built here asrustNotebookConfig.Depends on codedownio/notebook-language-server-core#1d1adc1.