Repository navigation
Move the Initialize rewrite and the custom method name into the NotebookConfig - #11
Merged
Merged
Conversation
thomasjm
force-pushed
the
client-not-config
branch
from
October 12, 2026 03:18
4a31ac6 to
6a90253
Compare
thomasjm
force-pushed
the
client-req-config
branch
from
October 12, 2026 03:18
2d89434 to
01e9752
Compare
thomasjm
force-pushed
the
client-req-config
branch
from
October 12, 2026 03:19
01e9752 to
ad30b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientReq now comes from core as well. The two things that were rust-specific in it move into
rustNotebookConfig: pointing rust-analyzer's root at the shadow crate (cpp and go deliberately don't do this), and therust-analyzer/analyzerStatuscustom method name.Stacked on #9.