[Scotchester]

Closes #79, #83

---

Tested following the procedures documented at https://docs.calitp.org/docker-python-web/guides/testing-changes/ (Kudos, @jgravois!)

[Scotchester]

I wonder if this should be released as 2.0 or 1.1. Upgrading to 3.14 doesn't seem to be a breaking change for any of our use cases, but theoretically it could be for some.

[jgravois]

I wonder if this should be released as 2.0 or 1.1

i definitely think it makes sense to frame this as a breaking change and release as 2.0.0

[jgravois]

(Kudos, @jgravois!)

i can't take credit. that excellent doc predates me. that reminds me though...

ghcr.io/cal-itp/docker-python-web:main
# becomes
docker-python-web:app

shouldn't the first line ☝️ be something like this now?

ghcr.io/cal-itp/docker-python-web:[version]

ref: https://github.com/cal-itp/benefits/blob/8bc80f80d9eddfd4e04085d354aa0cbbd4b3a921/appcontainer/Dockerfile#L12

[Scotchester]

(Kudos, @jgravois!)

i can't take credit. that excellent doc predates me.

You don't give yourself enough credit! https://github.com/cal-itp/docker-python-web/commits/main/docs/guides/testing-changes.md

(Maybe you sourced the original text from some other place, though?)

that reminds me though...

ghcr.io/cal-itp/docker-python-web:main
# becomes
docker-python-web:app

shouldn't the first line ☝️ be something like this now?

ghcr.io/cal-itp/docker-python-web:[version]

Yeah, good call, I'll update that.

[jgravois]

lgtm! 🥼

[Scotchester]

I wonder if this should be released as 2.0 or 1.1. Upgrading to 3.14 doesn't seem to be a breaking change for any of our use cases, but theoretically it could be for some.

i definitely think it makes sense to frame this as a breaking change and release as 2.0.0

Would also like other devs' input here, please and thank you :) @thekaveman @angela-tran @lalver1

[jgravois]

related: #73 (comment) 😇