Skip to content

test: Fix flaky worker-thread source close test #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Oct 8, 2026
Merged

test: Fix flaky worker-thread source close test #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/unit/test_http_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,12 +1542,14 @@ def test_file_source_is_left_open_when_the_transport_stops_pulling_early() -> No

def test_generator_source_pulled_in_a_worker_thread_is_closed_once_its_chunk_arrives() -> None:
"""A source the transport is still pulling when the attempt ends is closed as soon as that chunk is produced."""
pulling = threading.Event()
release = threading.Event()
closed = Mock()

def slow_chunks() -> Iterator[bytes]:
try:
yield b'first chunk'
pulling.set()
release.wait()
yield b'second chunk'
finally:
Expand All @@ -1563,6 +1565,8 @@ def send_request(self, *, content: bytes | Iterator[bytes] | None, **kwargs: Any
self.kept = content
self.puller = threading.Thread(target=next, args=(content, None))
self.puller.start()
# The attempt must end while the worker thread is inside the source, or the source closes right away.
assert pulling.wait(timeout=5)
return Mock(status_code=408)

transport = InFlightTransport()
Expand Down
Loading