Repository navigation
test: Fix flaky worker-thread source close test - #1108
Merged
Merged
Conversation
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 61 61
Lines 5880 5880
=======================================
Hits 5610 5610
Misses 270 270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 8, 2026 08:00
apify-service-account
added
the
tested
![apify-approval-mirror[bot]](https://avatars.githubusercontent.com/u/24586296?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_generator_source_pulled_in_a_worker_thread_is_closed_once_its_chunk_arrivesfailed on Windows in this run. The test started the puller thread and returned the 408 right away. If the thread had not entered the generator yet,close_chunks()closed the idle generator at once, so the source was closed before the test released it.The source now sets an event just before it blocks, and the fake transport waits for it before responding. The attempt always ends while the worker thread is inside the source. Delaying every thread start by 50 ms reproduced the failure 20/20 before the change and 0/100 after.
✍️ Drafted by Claude Code