Skip to content

docs: document the 404 behavior of log.get_as_bytes() and log.stream() - #1104

Merged
vdusek merged 2 commits into
masterfrom
docs/log-get-as-bytes-404
Oct 8, 2026
Merged

vdusek merged 2 commits into
masterfrom
docs/log-get-as-bytes-404

Conversation

@vdusek

@vdusek vdusek commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Adds the 404 note from log.get() to the sync and async get_as_bytes() and stream() docstrings. A 404 returns None only when the client targets a log by ID (client.log(run_id)). A chained client (run.log()) raises it.

Closes: #1103

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 8, 2026
@vdusek vdusek self-assigned this Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (966d3d6) to head (393fb4a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          61       61           
  Lines        5880     5880           
=======================================
  Hits         5610     5610           
  Misses        270      270           
Flag Coverage Δ
integration 91.29% <ø> (+0.05%) ⬆️
unit 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek changed the title docs: document the 404 behavior of log.get_as_bytes() docs: document the 404 behavior of log.get_as_bytes() and log.stream() Oct 8, 2026
@vdusek
vdusek marked this pull request as ready for review October 8, 2026 07:44
@vdusek
vdusek requested a review from Mantisus October 8, 2026 07:44

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit e7131fe into master Oct 8, 2026
31 of 32 checks passed
@vdusek
vdusek deleted the docs/log-get-as-bytes-404 branch October 8, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the 404 behavior of log.get_as_bytes()

3 participants