Skip to content

Document the 404 behavior of log.get_as_bytes() #1103

Closed

Description

@vdusek

log.get_as_bytes() (_resource_clients/log.py:67, async at :175) behaves like get() on a 404, but its docstring leaves out the caveat that get() has: a 404 becomes None only when the client targets a log by ID (client.log(run_id)), while a chained client (run.log()) raises. Copy the note into both docstrings.

✍️ Drafted by Claude Code

Activity

  1. added
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Oct 8, 2026
  2. self-assigned this
    on Oct 8, 2026
  3. added a commit that references this issue on Oct 8, 2026
    e7131fe
  4. vdusek commented on Oct 8, 2026

    @vdusek
    ContributorAuthor

    Resolved by #1104.

    ✍️ Drafted by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions