Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/magpie-pr-management/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ when_to_use: |
produced reviewable PRs; skip when triage has not engaged the PR.
argument-hint: "[pr:N] [area:LBL] [collab:true|false] [team:NAME] [ready] [dry-run]"
capability: capability:review
surface_hash: sha256:97ef701d93960492
surface_hash: sha256:871da2459ce53192
license: Apache-2.0
measured_tokens: 4119
---
Expand Down
11 changes: 11 additions & 0 deletions plugins/magpie-pr-management/skills/code-review/prerequisites.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,17 @@ this check says so.
If `gh auth status` fails entirely, surface it and ask the
maintainer to run `gh auth login`. Do not proceed.

### A save directory for the reads

Every saved read goes through `vetted-op-read --save`, which writes only into a `saved/` directory under the vetted-ops workspace that holds a `.vetted-ops-save` marker. It creates neither.
If a save refuses with *"holds no .vetted-ops-save file"* or *"is unusable"*, at any point in the run, ask the maintainer to create them (the workspace path is in the refusal):

```bash
mkdir -p -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
```

A `saved` that is a symlink stays unusable: `--save` refuses it, so replace it with a real directory first.

---

## 2. Resolve adversarial-reviewer configuration (DEGRADES)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ Every read in this skill is saved with `vetted-op-read --save`, which writes onl
If the first save refuses with *"holds no .vetted-ops-save file"* or *"is unusable"*, ask the maintainer to create it once (the workspace path is in the refusal):

```bash
mkdir -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
mkdir -p -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
```

A `saved` that is a symlink stays unusable: `--save` refuses it, so replace it with a real directory first.

---

## 2–3. Viewer permission and the triage labels
Expand Down
2 changes: 1 addition & 1 deletion plugins/magpie-vetted-ops/tools/vetted-ops/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ kilobytes — which a deterministic tool then reads from the file.
inside its own writable roots, could already write there. Create them once:

```bash
mkdir -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
mkdir -p -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
```

- The workspace passes the same ownership and mode checks as for body files;
Expand Down
2 changes: 1 addition & 1 deletion tools/vetted-ops/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ kilobytes — which a deterministic tool then reads from the file.
inside its own writable roots, could already write there. Create them once:

```bash
mkdir -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
mkdir -p -m 700 <workspace>/saved && touch <workspace>/saved/.vetted-ops-save
```

- The workspace passes the same ownership and mode checks as for body files;
Expand Down