Repository navigation
fix(code-review): document the save directory and make its recovery repeatable - #2028
Merged
Merged
Conversation
…epeatable code-review saves its reads with vetted-op-read --save but never said what to do when --save refuses for a missing .vetted-ops-save marker. The documented recovery used a plain mkdir, which fails when saved/ exists and only the marker is gone, so the touch never ran. Use mkdir -p, and note that a symlinked saved stays unusable. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-reviewsaves its reads throughvetted-op-read --savebut, unlikepr-triage, never says what to do when--saverefuses for a missing.vetted-ops-savemarker. Its prerequisites now cover that.mkdir -m 700 <workspace>/saved && touch …, fails whensaved/exists and only the marker is gone:mkdirerrors, so&&skips thetouch. It is nowmkdir -p -m 700, in both skills and thevetted-opsREADME. Both skills also note that a symlinkedsavedstays unusable, sincemkdir -paccepts one and--savedoes not.Seen on apache/airflow#76510: the marker went missing mid-session while
saved/stayed. The cause was not established; this change only makes the recovery work.Type of change
.claude/skills/<name>/) — eval fixtures updated belowdocs/,README.md,CONTRIBUTING.md)Test plan
prek run --files <changed files>passes; it updatedsurface_hashincode-reviewand the plugin copy of the READMEsaved/let--savework again on Post the first fork CI comment without waiting for the next run airflow#76510RFC-AI-0004 compliance
Linked issues
None found.
🤖 Generated with Claude Code