Skip to content

fix(code-review): document the save directory and make its recovery repeatable - #2028

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/code-review-save-marker-doc
Nov 9, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/code-review-save-marker-doc

Conversation

@potiuk

@potiuk potiuk commented Nov 9, 2026

Copy link
Copy Markdown
Member

Summary

  • code-review saves its reads through vetted-op-read --save but, unlike pr-triage, never says what to do when --save refuses for a missing .vetted-ops-save marker. Its prerequisites now cover that.
  • The documented recovery, mkdir -m 700 <workspace>/saved && touch …, fails when saved/ exists and only the marker is gone: mkdir errors, so && skips the touch. It is now mkdir -p -m 700, in both skills and the vetted-ops README. Both skills also note that a symlinked saved stays unusable, since mkdir -p accepts one and --save does not.

Seen on apache/airflow#76510: the marker went missing mid-session while saved/ stayed. The cause was not established; this change only makes the recovery work.

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Documentation (docs/, README.md, CONTRIBUTING.md)

Test plan

RFC-AI-0004 compliance

  • HITL — the maintainer still creates the directory and marker

Linked issues

None found.

🤖 Generated with Claude Code

…epeatable

code-review saves its reads with vetted-op-read --save but never said
what to do when --save refuses for a missing .vetted-ops-save marker.
The documented recovery used a plain mkdir, which fails when saved/
exists and only the marker is gone, so the touch never ran. Use
mkdir -p, and note that a symlinked saved stays unusable.

Generated-by: Claude Opus 5
@potiuk potiuk added family:pr-management pr-management-* skills capability:fix Implement code change to resolve an issue labels Nov 9, 2026
@github-actions github-actions Bot added family:tools tools/* family:docs Docs, MISSION.md, READMEs capability:triage Sweep + classify + propose disposition capability:review Deep per-item code review or contributor mentoring substrate:sandbox Tool substrate: agent isolation, egress control, settings audit labels Nov 9, 2026
@potiuk
potiuk merged commit 2628284 into apache:main Nov 9, 2026
10 checks passed
@potiuk
potiuk deleted the fix/code-review-save-marker-doc branch November 9, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:fix Implement code change to resolve an issue capability:review Deep per-item code review or contributor mentoring capability:triage Sweep + classify + propose disposition family:docs Docs, MISSION.md, READMEs family:pr-management pr-management-* skills family:tools tools/* substrate:sandbox Tool substrate: agent isolation, egress control, settings audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant