Repository navigation
JSPWIKI-1369 Make the integration tests pass again - #638
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
The tests wait for the menus to open, for the live preview to refresh and for the page that follows a login or a save, instead of reading the page while it is still loading. The editor refreshes its preview on input events, which setting the value of the field does not fire, so the test fires one. The test user database gets the oldhashes column the JDBC user database writes, and the web descriptors of the test wars use the Jakarta namespace the container authorizer looks for. The login test expects the login name, which is what the wiki shows for the logged in user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests read the page before the menus, the live preview or the page that follows a login or a save were ready, and three assumptions in the test setup were out of date.
oldhashescolumn thatJDBCUserDatabasewrites.WebContainerAuthorizerlooks for. With the old namespace the container authentication was not detected and the login of thecmamodules failed.LoginITexpects the login name, which is what the wiki shows for a logged in user.Executed on this branch, with
-Pintegration-testsand one module at a time:jspwiki-it-test-custom,custom-absolute-urls,custom-jdbc,cmaandcma-jdbceach run 7 tests, 0 failures. Before the changecustomfailed 5 tests and the other modules failed 3 or 4 on the same code.mvn clean package -Pintegration-testson the whole reactor succeeds.The CI job runs
package, which stops before the integration-test phase, so these tests are not run by CI.@spyhunter99