Skip to content

JSPWIKI-1373 Define the oldhashes column in the HSQL user database script - #639

Open
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:fix-ddl-oldhashes
Open

arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:fix-ddl-oldhashes

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

JDBCUserDatabase writes the oldhashes column for every new user, but hsql.ddl, the script the war ships to create the tables, did not define it. With a database created from that script the profile of a new user cannot be saved.

Executed with HSQLDB 2.7.4: the INSERT statement of JDBCUserDatabase fails against the tables created by the script on master ("user lacks privilege or object not found: OLDHASHES") and inserts the row once the column is defined. The script of the integration tests got the same column in #638.

postgresql.ddl has a separate problem, not changed here: it uses HSQL types and a trailing comma, so the users table is not created on PostgreSQL 16.

…ript

JDBCUserDatabase writes the oldhashes column for every new user, but the
script the war ships to create the tables did not define it, so the
profile of a new user could not be saved in a database created from it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant