Repository navigation
JSPWIKI-1373 Define the oldhashes column in the HSQL user database script - #639
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…ript JDBCUserDatabase writes the oldhashes column for every new user, but the script the war ships to create the tables did not define it, so the profile of a new user could not be saved in a database created from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDBCUserDatabasewrites theoldhashescolumn for every new user, buthsql.ddl, the script the war ships to create the tables, did not define it. With a database created from that script the profile of a new user cannot be saved.Executed with HSQLDB 2.7.4: the INSERT statement of
JDBCUserDatabasefails against the tables created by the script on master ("user lacks privilege or object not found: OLDHASHES") and inserts the row once the column is defined. The script of the integration tests got the same column in #638.postgresql.ddlhas a separate problem, not changed here: it uses HSQL types and a trailing comma, so theuserstable is not created on PostgreSQL 16.