Skip to content

JSPWIKI-1368 Run the unpack of the war in the portable module after the war is packaged - #634

Open
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:portable-phase
Open

arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:portable-phase

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

mvn clean test stops at jspwiki-portable: maven-dependency-plugin:unpack (unpack-jspwiki-war) fails with "Artifact has not been packaged yet" (MDEP-98), because the module unpacks the war of the reactor in generate-resources and test does not package it. It happens with the 3.0.0 source and with the source of 3.0.1 RC2, and it was reported on the vote thread of RC2. The cheat sheet recommends mvn clean test.

The unpacks of the war, of the wikipages and of Tomcat, and woas:copy-woas, now run in prepare-package, when the war exists. The dependency plugin is declared before antrun, so in the same phase the unpacks still run first, as before.

Run on this change: mvn clean test passes in all the modules (1169 tests in jspwiki-main); mvn clean package with all the tests (1445 tests), verify and install pass; the woas zip of jspwiki-portable has the same SHA-256 as the one built before the change; the portable, with its own Tomcat, and the war on Tomcat 10.1 start and answer.

@spyhunter99

…aged

jspwiki-portable unpacked the war of jspwiki-war, the wikipages and Tomcat in the generate-resources phase, and copied the exploded war in process-resources. mvn test does not package the war, so the build stopped at the unpack with MDEP-98. The unpacks and the copy now run in prepare-package, unpack first, which is when the war exists. The portable zip is the same as before.
@arturobernalg arturobernalg changed the title Run the unpack of the war in the portable module after the war is packaged JSPWIKI-1368 Run the unpack of the war in the portable module after the war is packaged Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant