Repository navigation
JSPWIKI-1368 Run the unpack of the war in the portable module after the war is packaged - #634
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…aged jspwiki-portable unpacked the war of jspwiki-war, the wikipages and Tomcat in the generate-resources phase, and copied the exploded war in process-resources. mvn test does not package the war, so the build stopped at the unpack with MDEP-98. The unpacks and the copy now run in prepare-package, unpack first, which is when the war exists. The portable zip is the same as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvn clean teststops at jspwiki-portable: maven-dependency-plugin:unpack (unpack-jspwiki-war) fails with "Artifact has not been packaged yet" (MDEP-98), because the module unpacks the war of the reactor in generate-resources andtestdoes not package it. It happens with the 3.0.0 source and with the source of 3.0.1 RC2, and it was reported on the vote thread of RC2. The cheat sheet recommendsmvn clean test.The unpacks of the war, of the wikipages and of Tomcat, and woas:copy-woas, now run in prepare-package, when the war exists. The dependency plugin is declared before antrun, so in the same phase the unpacks still run first, as before.
Run on this change:
mvn clean testpasses in all the modules (1169 tests in jspwiki-main);mvn clean packagewith all the tests (1445 tests),verifyandinstallpass; the woas zip of jspwiki-portable has the same SHA-256 as the one built before the change; the portable, with its own Tomcat, and the war on Tomcat 10.1 start and answer.@spyhunter99