Repository navigation
JSPWIKI-1368 Unpack the war of the portable module only when the war has been packaged - #640
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…has been packaged jspwiki-portable unpacked the war of jspwiki-war, the wikipages and Tomcat in the generate-resources phase, and copied the exploded war in process-resources. mvn test does not package the war, so the build stopped at the unpack with MDEP-98. The unpacks and the copy now run in prepare-package, unpack first, which is when the war exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #634 to master-2.x.
jspwiki-portableunpacked the war ofjspwiki-war, the wikipages and Tomcat ingenerate-resources, and copied the exploded war inprocess-resources.mvn testdoes not package the war, so the build stopped at the unpack with MDEP-98. The unpacks and the copy now run inprepare-package, unpack first, which is when the war exists.Executed on this branch:
mvn clean teston the whole reactor succeeds, andmvn clean package -DskipTestsbuildsjspwiki-portable-2.12.6-SNAPSHOT-woas.zip, which contains the Tomcat launcher and libraries and the web.xml of the personal, department and ROOT wikis.