Skip to content

Fix hang in stream ID validation test #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 1 commit into from
Sep 1, 2026
+5 −1
Merged

Fix hang in stream ID validation test #3513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/brpc_streaming_rpc_unittest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,12 +1366,13 @@ class MyServiceWithMismatchedExtraStreamIds : public test::EchoService {
settings->add_extra_stream_ids(settings->extra_stream_ids(0));
}

brpc::StreamIds response_streams;
ASSERT_EQ(0, brpc::StreamAccept(response_streams, *cntl, nullptr));
ASSERT_EQ((int)_stream_count + _adjustment,
(int)response_streams.size());
}

brpc::StreamIds response_streams;

private:
size_t _stream_count;
int _adjustment;
Expand Down Expand Up @@ -1486,6 +1487,9 @@ TEST_F(StreamingRpcTest, reject_mismatched_returned_stream_identifiers) {
brpc::StreamUniquePtr stream;
ASSERT_NE(0, brpc::Stream::Address(stream_id, &stream));
}
for (brpc::StreamId stream_id : service.response_streams) {
ASSERT_EQ(0, brpc::StreamClose(stream_id));
}

server.Stop(0);
server.Join();
Expand Down
Loading