Fix hang in stream ID validation test - #3513
Open
wasphin wants to merge 1 commit into
Open
Conversation
Close the server-side streams accepted by the mismatched stream ID test before stopping the server. This prevents Server::Join from waiting indefinitely for streams left open by the intentionally rejected response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
The mismatched returned stream ID test could hang in
Server::Join. Theintentionally rejected response left server-side accepted streams open.
Related discussion: #3485 (comment)
What is changed and the side effects?
Changed:
The test now retains and closes the server-side accepted streams before
stopping and joining the server.
Side effects:
Performance effects: None. The change only affects a unit test.
Breaking backward compatibility: No.
Check List: