Skip to content

Add a pull request lifecycle diagram for fork CI - #76839

Merged
potiuk merged 2 commits into
fork-ci-test-merge-with-targetfrom
fork-ci-pr-lifecycle-diagram
Nov 15, 2026
Merged

potiuk merged 2 commits into
fork-ci-test-merge-with-targetfrom
fork-ci-pr-lifecycle-diagram

Conversation

@potiuk

@potiuk potiuk commented Nov 10, 2026

Copy link
Copy Markdown
Member

Why

The fork CI design document only had the reconciler's internal state machine. Contributors and
maintainers asked during the AIP-120 vote what a gated pull request shows at each step and who has
to act next.

What

  • A "Pull request lifecycle" section with a Mermaid state diagram in
    dev/breeze/doc/ci/08_fork_ci_for_external_contributors.md: from opening to merge or close,
    including the failed, rebase-needed and CI-files-changed paths and use project ci.
  • The "CI in your fork" section of the contributor docs links to it, and its wiki link points at
    ADIP-12, the renamed AIP-120 page.

Stacked on #76837 (the rebase-needed state comes from it).

related: https://lists.apache.org/thread/5603zwgpj7pgj6j979hbgpr72xsjbbws


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

🤖 Generated with Claude Code

@potiuk
potiuk force-pushed the fork-ci-pr-lifecycle-diagram branch from 5f3c94b to f3911bf Compare November 10, 2026 22:46

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lifecycle diagram matches the reconciler's state machine well; a few exit paths are missing, none blocking. The three open threads from Andrushika (the use project ci push or reopen step, the author's-draft green state, and approved --> running) all look right to me, and the two comments below are in the same vein. They can be follow-ups.

Smaller observations

  • See inline comments on dev/breeze/doc/ci/08_fork_ci_for_external_contributors.md:145, dev/breeze/doc/ci/08_fork_ci_for_external_contributors.md:134.

This review was drafted by an AI-assisted tool and
confirmed by an Apache Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.

More on how Apache Airflow handles maintainer review:
Contributing guide.

The design document only had the reconciler's internal state machine. Add the contributor's and maintainer's view: what a gated pull request shows at each step, from opening to merge or close, and who acts next. Link it from the contributor docs, and point their ADIP-12 link at the renamed wiki page.

Generated-by: Claude Opus 5
The lifecycle diagram now has the author's draft green state, the way
back to running for an approved pull request, for one that needs project
CI and for a disabled fork workflow, and says that `use project ci` takes
effect on the next push or a close and reopen.

Generated-by: Claude Opus 5
@potiuk
potiuk force-pushed the fork-ci-pr-lifecycle-diagram branch from f3911bf to 4c07eb3 Compare November 15, 2026 01:26
@potiuk
potiuk merged commit d45e8ea into main Nov 15, 2026
104 checks passed
@potiuk
potiuk deleted the fork-ci-pr-lifecycle-diagram branch November 15, 2026 04:00
potiuk added a commit that referenced this pull request Nov 15, 2026
* [v3-4-test] Sync fork CI changes from main

Several fork CI changes merged to main since the last sync never reached
v3-4-test, and the fork CI monitor reads the gate configuration of a pull
request's base branch, so pull requests to v3-4-test were still closed
after 7 days and missed ten pilot participants. The fork CI modules, their
tests, the design document and its diagrams, the monitor workflow, the
gate configuration checks and the contributor documentation now match
main, taking in #75814, #75696, #76272, #76316, #76327, #76510, #76538,
#76677, #76681, #76835, #76836, #76837, #76839, #76841, #76866, #76267 and
#77100.

The pilot participants new to this branch join at 2026-11-16 00:00 UTC
rather than at their main dates, as the gate configuration check requires
a future instant for an entry that is new on the base branch.

Generated-by: Claude Opus 5

* [v3-4-test] Say the fork CI monitor runs every 5 minutes in the CI tasks doc

The sentence changed with #76836 on main and was missed by the sync.

Generated-by: Claude Opus 5

* [v3-4-test] Bring the fork CI GitHub client tests in line with main

The tests for the smaller job listing pages (#76327) were missed by the
sync; the client code they cover is already in it.

Generated-by: Claude Opus 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants