Skip to content

Generate the fork CI diagrams from one source with the diagrams prek hook - #76841

Merged
potiuk merged 2 commits into
fork-ci-pr-lifecycle-diagramfrom
fork-ci-diagrams-prek
Nov 15, 2026
Merged

potiuk merged 2 commits into
fork-ci-pr-lifecycle-diagramfrom
fork-ci-diagrams-prek

Conversation

@potiuk

@potiuk potiuk commented Nov 10, 2026

Copy link
Copy Markdown
Member

Why

The fork CI design document drew its architecture as ASCII art and its reconciler states and pull
request lifecycle in Mermaid. The ADIP-12 wiki page cannot render Mermaid and needs images, so
the same diagrams would exist twice and drift apart.

What

  • Graphviz sources for the three diagrams as dev/breeze/doc/ci/images/diagram_fork_ci_*.py,
    registered with the existing generate-airflow-diagrams prek hook, which regenerates an SVG
    (and its .md5sum) whenever its source changes, like the other diagrams in the repository.
  • The design document embeds the generated SVGs instead of the ASCII art and the Mermaid blocks,
    so there is one source per diagram. The ADIP-12 wiki page embeds the same SVG files.

Stacked on #76839.

related: https://lists.apache.org/thread/5603zwgpj7pgj6j979hbgpr72xsjbbws


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

🤖 Generated with Claude Code

@potiuk
potiuk force-pushed the fork-ci-diagrams-prek branch from ff2ef96 to 64c72f8 Compare November 10, 2026 22:46
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

The re-run of the jobs stopped by EC2 Spot interruptions finished: attempt 2 passed.

…hook

The fork CI design document drew its architecture as ASCII art and its reconciler states and pull request lifecycle in Mermaid, while the ADIP-12 wiki page, which cannot render Mermaid, needs images. Keeping both copies would let them drift. Make Graphviz sources (diagram_fork_ci_*.py under dev/breeze/doc/ci/images/) the only copy: the generate-airflow-diagrams prek hook regenerates each SVG when its source changes, like the other diagrams in the repository, and the design document and the wiki page embed the same SVG files.

Generated-by: Claude Opus 5
The Graphviz source gains the transitions added to the Mermaid version in
review: the author's draft green state, the way back to running for an
approved pull request, for one that needs project CI and for a disabled
fork workflow, and when `use project ci` takes effect.

Generated-by: Claude Opus 5
@potiuk
potiuk force-pushed the fork-ci-diagrams-prek branch from 64c72f8 to 4cedcd4 Compare November 15, 2026 01:26
@potiuk
potiuk merged commit ba80755 into main Nov 15, 2026
177 checks passed
@potiuk
potiuk deleted the fork-ci-diagrams-prek branch November 15, 2026 04:00
potiuk added a commit that referenced this pull request Nov 15, 2026
* [v3-4-test] Sync fork CI changes from main

Several fork CI changes merged to main since the last sync never reached
v3-4-test, and the fork CI monitor reads the gate configuration of a pull
request's base branch, so pull requests to v3-4-test were still closed
after 7 days and missed ten pilot participants. The fork CI modules, their
tests, the design document and its diagrams, the monitor workflow, the
gate configuration checks and the contributor documentation now match
main, taking in #75814, #75696, #76272, #76316, #76327, #76510, #76538,
#76677, #76681, #76835, #76836, #76837, #76839, #76841, #76866, #76267 and
#77100.

The pilot participants new to this branch join at 2026-11-16 00:00 UTC
rather than at their main dates, as the gate configuration check requires
a future instant for an entry that is new on the base branch.

Generated-by: Claude Opus 5

* [v3-4-test] Say the fork CI monitor runs every 5 minutes in the CI tasks doc

The sentence changed with #76836 on main and was missed by the sync.

Generated-by: Claude Opus 5

* [v3-4-test] Bring the fork CI GitHub client tests in line with main

The tests for the smaller job listing pages (#76327) were missed by the
sync; the client code they cover is already in it.

Generated-by: Claude Opus 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants