Repository navigation
feat: add audience collection mode - #55
Merged
Merged
Conversation
3 tasks done
redox
reviewed
Nov 9, 2026
| timeout: { operation_timeout: @timeout }, | ||
| headers: @headers, | ||
| base_url: @base_url | ||
| origin: @base_url |
Member
Author
There was a problem hiding this comment.
Reverted. It fixed an existing HTTPX invalid URI: /track failure that also affects product mode on main, so it belongs in a separate fix(httpx) PR.
Server requests carry no visitor page context, cookies, or ambient credentials, so drop URL rewriting, endpoint credential checks, and transport tests. Caller properties now pass through unchanged.
Member
Author
|
Scope change following the spec update: server-tier audience mode is now only the wire shape ( |
redox
approved these changes
Nov 9, 2026
francoischalifour
added a commit
that referenced
this pull request
Nov 9, 2026
Every request through the HTTPX adapter fails on `main` with `HTTPX::Error: invalid URI: /track` (httpx 1.7.3): the client was configured with `base_url:`, which httpx does not use to resolve relative request paths. Configuring it with `origin:` resolves `/track`, `/identify` and `/alias` against the base URL, like the Faraday and Net::HTTP adapters. Adds a loopback delivery spec that posts a real track request through each adapter; it fails for HTTPX before this change. Split out of #55, where it was flagged as unrelated to audience mode.
francoischalifour
added a commit
that referenced
this pull request
Nov 9, 2026
## What Deprecate the `environment` option. It is still accepted (with a debug-mode warning) and the public default constant is retained, but it is ignored for routing and never sent: request payloads no longer include an `environment` field for scalar, hash, batch, identify, or alias calls. Nested business properties named `environment` are preserved. README, changelog, and RBS/RBI typings mark the option as deprecated. ## Why An environment-bound Product Analytics API key now selects the destination. Callers using unbound legacy keys must replace them before upgrading. Stacked on #55 (audience collection); this PR contains only the environment slice. ## Checklist - [x] Client specs verify the deprecated option is accepted and `environment` is omitted from scalar, hash, batch, identify, and alias requests while nested properties are preserved. - [x] Audience and product specs updated for the removed field. - [x] Changelog and README updated; the compatibility impact (unbound keys require migration) is noted in the changelog.
francoischalifour
pushed a commit
that referenced
this pull request
Nov 17, 2026
🤖 I have created a release *beep* *boop* --- ## [1.4.0](altertable/v1.3.0...altertable/v1.4.0) (2026-11-09) ### Features * add audience collection mode ([#55](#55)) ([7ecb88c](7ecb88c)) * deprecate analytics environment routing ([#56](#56)) ([020e3bf](020e3bf)) ### Bug Fixes * **httpx:** resolve request paths against the base URL ([#57](#57)) ([f3473fb](f3473fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add immutable
mode: :audiencefor scalar, hash, and batch tracking. Audience events send onlymode,event,timestamp, andproperties; per-event options and hash or batch fields cannot override the client's mode.identifyandaliasare ignored (with a stderr warning whendebugis enabled), anddistinct_idis not required. Caller properties pass through unchanged. Product mode remains the default, and an invalidmoderaisesConfigurationErrorbefore a transport is created.The HTTPX
origin:fix that was originally part of this PR is now in #57.Why
Server callers need restricted event collection without product identifiers. Custom properties remain the application's responsibility, and server HTTP context does not represent individual visitors.
Checklist