Repository navigation
feat: deprecate analytics environment routing - #56
Merged
Merged
Conversation
francoischalifour
force-pushed
the
feat/environment-routing-pr
branch
from
November 9, 2026 13:35
371bedb to
b04d136
Compare
Member
Author
|
Rebased on the updated audience PR. Removed |
redox
approved these changes
Nov 9, 2026
redox
reviewed
Nov 9, 2026
| @api_key = api_key | ||
| @base_url = options[:base_url] || DEFAULT_BASE_URL | ||
| @environment = options[:environment] || DEFAULT_ENVIRONMENT | ||
| warn "[Altertable] The environment is determined by your API key. Remove the :environment option." if options.key?(:environment) && options[:debug] |
Member
There was a problem hiding this comment.
we usually don't do any logging on the backend - I would remove this
Suggested change
| warn "[Altertable] The environment is determined by your API key. Remove the :environment option." if options.key?(:environment) && options[:debug] |
Member
Author
There was a problem hiding this comment.
Removed, along with the equivalent debug warning for ignored identify/alias calls in #55.
francoischalifour
force-pushed
the
feat/environment-routing-pr
branch
from
November 9, 2026 14:05
97bfca7 to
d46e6de
Compare
Payload builders select fields explicitly, so environment cannot reach the wire once the client stops adding it. Migration guidance belongs on the docs site.
francoischalifour
changed the base branch from
feat/audience-collection-pr
to
main
November 9, 2026 14:16
francoischalifour
force-pushed
the
feat/environment-routing-pr
branch
from
November 9, 2026 14:17
d46e6de to
2c16d9b
Compare
francoischalifour
pushed a commit
that referenced
this pull request
Nov 17, 2026
🤖 I have created a release *beep* *boop* --- ## [1.4.0](altertable/v1.3.0...altertable/v1.4.0) (2026-11-09) ### Features * add audience collection mode ([#55](#55)) ([7ecb88c](7ecb88c)) * deprecate analytics environment routing ([#56](#56)) ([020e3bf](020e3bf)) ### Bug Fixes * **httpx:** resolve request paths against the base URL ([#57](#57)) ([f3473fb](f3473fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deprecate the
environmentoption. It is still accepted (with a debug-mode warning) and the public default constant is retained, but it is ignored for routing and never sent: request payloads no longer include anenvironmentfield for scalar, hash, batch, identify, or alias calls. Nested business properties namedenvironmentare preserved. README, changelog, and RBS/RBI typings mark the option as deprecated.Why
An environment-bound Product Analytics API key now selects the destination. Callers using unbound legacy keys must replace them before upgrading.
Stacked on #55 (audience collection); this PR contains only the environment slice.
Checklist
environmentis omitted from scalar, hash, batch, identify, and alias requests while nested properties are preserved.