Repository navigation
fix: return ICMP feedback for rejected UDP flows - #3
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDP flows rejected by a VPN policy previously closed without notifying the originating application, leaving QUIC attempts to time out. Add a consuming UDP rejection API that returns IPv4/IPv6 ICMP port unreachable with the original request quoted, then releases the flow. Suppress multicast/broadcast feedback and reject calls after data was consumed.
Validation:
cargo test --manifest-path deps/ipstack/Cargo.toml;cargo clippy --manifest-path deps/ipstack/Cargo.toml --all-targets --all-features -- -D warnings;cargo fmt --manifest-path deps/ipstack/Cargo.toml -- --check. Parent packet-tunnel integration verifies v4/v6 checksums, exact quotation, MTU bounds, DNS exemption and immediate rejection. Verified on an iPhone with Edge Google searches.No proxy wire or C ABI changes. Existing UDP send/receive APIs remain compatible; the new API is documented in source.