Repository navigation
fix: support destination UDP policy and immediate rejection - #12
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked UDP previously disappeared without feedback. Return ICMP port unreachable instead, and let embedded packet tunnels select direct, proxy or reject by destination before opening a socket. Keep DNS and explicit process bypass ahead of the ordinary UDP policy, and preserve existing CLI behavior for other strategies.
Requires acking-you/ipstack#3; the CI checkout is pinned to its exact commit. No proxy wire or C ABI changes. The embedded policy API is documented in source.
Validation:
cargo test --manifest-path deps/tun2proxy/Cargo.toml(73 passed),cargo clippy --manifest-path deps/tun2proxy/Cargo.toml --all-targets --all-features -- -D warnings, andcargo fmt --manifest-path deps/tun2proxy/Cargo.toml -- --check. Parent packet-tunnel integration covers DNS exemption, direct UDP and immediate v4/v6 rejection; iPhone tests verified mainland direct UDP and 1–13 ms rejection of foreign UDP with proxying disabled.