Repository navigation
fix: preserve UDP datagrams across MTU fragmentation - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large replies were split into independent UDP datagrams at MTU boundaries, changing the application's message framing. Emit IPv4/IPv6 fragments of one checksummed UDP datagram instead, and expose datagram-aware
recv/sendso an empty packet is not treated as stream EOF.The focused regression verifies IPv4/IPv6 fragment offsets, reconstructed payload, empty packets and oversized rejection. Existing stream traits remain available. Incoming IP fragment reassembly is unchanged.
Validation on Windows, without creating a TUN device:
cargo test --manifest-path deps/ipstack/Cargo.toml --target-dir target— 13 unit and 23 doc tests passed.cargo clippy --manifest-path deps/ipstack/Cargo.toml --target-dir target --all-targets --all-features -- -D warningscargo fmt --manifest-path deps/ipstack/Cargo.toml -- --checkCI now executes library tests as well as examples. README documents the datagram API. No native proxy wire-format or FFI ABI change.