Repository navigation
fix: bind desktop DNS and process bypass to physical egress - #5
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop process exclusions could connect directly while resolving names at the proxy exit, producing inconsistent CDN destinations. Windows adapter discovery also performed synchronous gateway ARP probing, including against the TUN portal.
Add desktop physical DNS with ordered AliDNS/Tencent DNSPod, adapter DNS and configured fallback. Reuse the interface-bound resolver for excluded processes, handle UDP-to-TCP fallback and DNS truncation, and keep Fake-IP recovery. Windows egress detection reads passive route/adapter snapshots with gateway MAC probing disabled. Platform VPN DNS modes stay separate.
Expose a loopback process matcher that excludes the embedding PID before ancestor matching. Use datagram-aware forwarding for empty/large UDP, retain associations after malformed SOCKS UDP replies, and record interface/endpoints/counts/close reason. Requires acking-you/ipstack#1; CI checks out that exact commit and now runs unit tests.
Validation (Windows, loopback/simulated devices only):
cargo test --manifest-path deps/tun2proxy/Cargo.toml --target-dir target— 87 passed.cargo clippy --manifest-path deps/tun2proxy/Cargo.toml --target-dir target --all-targets --all-features -- -D warningscargo fmt --manifest-path deps/tun2proxy/Cargo.toml -- --checkcargo check -p proxy-ffi --target aarch64-linux-android --lockedwith local Android NDK.Reviews covered owner matching and loop prevention; DNS framing/cancellation/old Fake-IP state; then empty/large UDP and observability. The same loopback HTTP/SOCKS/UDP regression fell from about 25 s to 0.43 s after disabling Windows ARP probing. This is a local measurement, not an in-game benchmark.
No proxy wire-format change; existing DNS enum values retain their numeric values. README describes the new opt-in physical mode. No running TUN, routes, system DNS or existing configuration was modified during validation.
Standalone CI uses the consumer's nightly-2026-01-26 toolchain and a committed Cargo.lock with libc 0.2.189. The legacy public-network test matrix now captures its parameters correctly and skips missing proxy credentials or an unavailable IPv6 route explicitly. The twelve combinations were checked offline without starting a TUN. Consumer integration: acking-you/proxy-everything#27.