fix: Multitenancy support for public agent card doesn't match the client. - #1111
Open
ehsavoie wants to merge 2 commits into
Open
fix: Multitenancy support for public agent card doesn't match the client.#1111ehsavoie wants to merge 2 commits into
ehsavoie wants to merge 2 commits into
Conversation
- Was calling extractTenant() (full normalized path) instead of rc.pathParam("tenant")
- Add tests/multitenancy/jsonrpc: proves tenant public cards work without REST on classpath
Fixes a2aproject#1106
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
changed the title
- Align client URL pattern with server route: embed tenant inside well-known path - Add fallback to original base URL when computed card URL returns HTTP error - Extend stripWellKnownSuffix to handle tenant-specific suffixes Fixes: a2aproject#1107 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #1110
Fixes #1107 🦕