feat(multitenancy): return 404 for unknown tenant on public agent card - #1112
Open
ehsavoie wants to merge 1 commit into
Open
feat(multitenancy): return 404 for unknown tenant on public agent card#1112ehsavoie wants to merge 1 commit into
ehsavoie wants to merge 1 commit into
Conversation
ehsavoie
changed the title
Collaborator
|
@ehsavoie Needs a rebase |
Collaborator
Author
|
@kabir rebased |
- Add TenantNotFoundException; JSONRPCHandler and RestHandler throw/return 404 when AgentCardRouter is set but tenant not found - Single-tenant servers (no router) ignore the tenant segment and serve the default card - CdiAgentCardRouter.resolvePublicCard now returns null for unknown/blank tenants instead of the default card - Add Utils.buildTenantCardPath helper; restrict fallback retry in A2ACardResolver to 404 only - Update all tests to expect 404 for unknown tenants Fixes: a2aproject#1108 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #1111
Fixes #1108 🦕