Skip to content

feat(settings): tabs in a column on the left #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wasabules merged 1 commit into from
Oct 27, 2026
Merged

feat(settings): tabs in a column on the left #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/assets/img/background-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/img/background-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/img/backups-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/img/backups-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
113 changes: 75 additions & 38 deletions frontend/src/components/Settings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,26 @@

type Tab = 'general' | 'storage' | 'backups' | 'background' | 'sources' | 'about';
let activeTab: Tab = 'general';
const TABS: { id: Tab; label: string }[] = [
{ id: 'general', label: 'settings.general' },
{ id: 'storage', label: 'settings.storage' },
{ id: 'backups', label: 'backup.tab' },
{ id: 'background', label: 'background.tab' },
{ id: 'sources', label: 'sources.tab' },
{ id: 'about', label: 'settings.about' },
];
let tabButtons: HTMLButtonElement[] = [];

// Up and down move along the list, as in any vertical tab list.
function onTabKeydown(e: KeyboardEvent) {
const step = e.key === 'ArrowDown' ? 1 : e.key === 'ArrowUp' ? -1 : 0;
if (!step) return;
e.preventDefault();
const i = TABS.findIndex(t => t.id === activeTab);
const next = (i + step + TABS.length) % TABS.length;
activeTab = TABS[next].id;
tabButtons[next]?.focus();
}
$: if (visible && initialTab) activeTab = initialTab;
// A dialog open inside the Background or Backups tab takes Escape first.
let backgroundOverlayOpen = false;
Expand Down Expand Up @@ -486,34 +506,17 @@
<button class="close-btn" on:click={onClose} aria-label={$_('common.close')}>&times;</button>
</div>

<div class="tabs">
<button class="tab" class:active={activeTab === 'general'}
on:click={() => activeTab = 'general'}>
{$_('settings.general')}
</button>
<button class="tab" class:active={activeTab === 'storage'}
on:click={() => activeTab = 'storage'}>
{$_('settings.storage')}
</button>
<button class="tab" class:active={activeTab === 'backups'}
on:click={() => activeTab = 'backups'}>
{$_('backup.tab')}
</button>
<button class="tab" class:active={activeTab === 'background'}
on:click={() => activeTab = 'background'}>
{$_('background.tab')}
</button>
<button class="tab" class:active={activeTab === 'sources'}
on:click={() => activeTab = 'sources'}>
{$_('sources.tab')}
</button>
<button class="tab" class:active={activeTab === 'about'}
on:click={() => activeTab = 'about'}>
{$_('settings.about')}
</button>
<div class="tabs" role="tablist" aria-orientation="vertical" tabindex="-1" on:keydown={onTabKeydown}>
{#each TABS as tab, i (tab.id)}
<button class="tab" class:active={activeTab === tab.id} role="tab"
aria-selected={activeTab === tab.id} tabindex={activeTab === tab.id ? 0 : -1}
bind:this={tabButtons[i]} on:click={() => activeTab = tab.id}>
{$_(tab.label)}
</button>
{/each}
</div>

<div class="modal-body">
<div class="modal-body" role="tabpanel">
{#if activeTab === 'general'}
<div class="form-group">
<label for="settings-theme">{$_('settings.theme')}</label>
Expand Down Expand Up @@ -915,25 +918,29 @@
z-index: 200;
}

/* The tabs in a column on the left of the body, header and footer across
both. One size whatever the tab, so the column does not move. */
.modal {
background: var(--bg-secondary);
border: 1px solid var(--border-color);
border-radius: 8px;
width: 520px;
width: 860px;
max-width: 95vw;
height: 680px;
max-height: 88vh;
display: flex;
flex-direction: column;
display: grid;
grid-template-columns: 180px minmax(0, 1fr);
grid-template-rows: auto minmax(0, 1fr) auto;
box-shadow: 0 8px 32px var(--shadow-color);
}

.modal-header {
grid-column: 1 / -1;
display: flex;
align-items: center;
justify-content: space-between;
padding: 12px 16px;
border-bottom: 1px solid var(--border-color);
flex-shrink: 0;
}

.modal-title { font-size: 14px; font-weight: 600; }
Expand All @@ -948,38 +955,68 @@

.tabs {
display: flex;
border-bottom: 1px solid var(--border-color);
flex-shrink: 0;
flex-direction: column;
gap: 2px;
padding: 10px 8px 10px 0;
background: var(--bg-tertiary);
border-right: 1px solid var(--border-color);
overflow-y: auto;
}

.tab {
flex: 1;
padding: 8px 16px;
padding: 8px 12px 8px 14px;
background: transparent;
color: var(--text-secondary);
font-size: 12px;
font-weight: 600;
text-align: left;
border: none;
border-bottom: 2px solid transparent;
border-left: 2px solid transparent;
border-radius: 0 4px 4px 0;
cursor: pointer;
}
.tab:hover { color: var(--text-primary); background: var(--bg-hover); }
.tab.active { color: var(--accent); border-bottom-color: var(--accent); }
.tab.active { color: var(--accent); background: var(--accent-bg); border-left-color: var(--accent); }

.modal-body {
padding: 16px;
padding: 16px 20px;
overflow-y: auto;
display: flex;
flex-direction: column;
gap: 12px;
}

.modal-footer {
grid-column: 1 / -1;
display: flex;
justify-content: flex-end;
padding: 10px 16px;
border-top: 1px solid var(--border-color);
flex-shrink: 0;
}

/* Too narrow for a column: the tabs go back above the body. */
@media (max-width: 700px) {
.modal {
grid-template-columns: minmax(0, 1fr);
grid-template-rows: auto auto minmax(0, 1fr) auto;
}
.tabs {
flex-direction: row;
gap: 0;
padding: 0;
border-right: none;
border-bottom: 1px solid var(--border-color);
overflow-x: auto;
overflow-y: hidden;
}
.tab {
flex: 1;
white-space: nowrap;
border-left: none;
border-bottom: 2px solid transparent;
border-radius: 0;
}
.tab.active { border-bottom-color: var(--accent); }
}
.close-footer-btn {
background: var(--bg-tertiary);
Expand Down
Loading