Repository navigation
feat(settings): tabs in a column on the left - #97
Merged
Merged
Conversation
Six tabs across a 520 px dialog left each one a narrow label, and the dialog changed height with every tab. The tabs now run down the left of a wider dialog (860 px, 95% of the window at most) of one fixed height, so the list stays put and the body gets the width of a desktop screen. Below 700 px, the demo on a phone, they go back above the body. The tab list is built from one array, with tablist/tab roles and the up and down arrows moving along it. The Background and Backups screenshots are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings had six tabs across the top of a 520 px dialog: each label was squeezed, and the dialog changed height with every tab.
What changes
tablist/tabroles, and the up and down arrows move along it..tabclass and the tab order are unchanged, so the screenshot scenes still find them.Checked
svelte-check --fail-on-warnings: no errors or warnings.