Repository navigation
[TS] Concatenate symbolic strings - #460
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-424-symbolic-concat
branch
from
October 2, 2026 22:12
137c2bf to
6709ce3
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-421-symbolic-string
to
caelmbleidd/ts-422-string-value-equality
October 2, 2026 22:13
CaelmBleidd
force-pushed
the
caelmbleidd/ts-424-symbolic-concat
branch
from
October 2, 2026 23:04
6709ce3 to
ba5bfb6
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-422-string-value-equality
to
caelmbleidd/ts-423-string-truthiness
October 2, 2026 23:05
CaelmBleidd
force-pushed
the
caelmbleidd/ts-423-string-truthiness
branch
from
October 3, 2026 05:26
2c08f04 to
9d511c1
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-424-symbolic-concat
branch
4 times, most recently
from
October 3, 2026 06:30
9af3ed8 to
5760fe8
Compare
CaelmBleidd
marked this pull request as ready for review
October 3, 2026 06:43
CaelmBleidd
force-pushed
the
caelmbleidd/ts-423-string-truthiness
branch
from
October 5, 2026 13:09
7fe2676 to
f2a22c3
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-424-symbolic-concat
branch
from
October 7, 2026 21:13
42bf75a to
5df0eb1
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-424-symbolic-concat
branch
from
October 9, 2026 10:36
5df0eb1 to
ae79f17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #424.
Symbolic string concatenation copies UTF-16 code units between the same private backing arrays used by string inputs, equality, typed fields and witness extraction. It preserves operand evaluation order and supported concrete primitive conversions; results above
maxArraySizeproduce explicit unsupported paths.String-only unions inferred for expressions such as
(value && "a") + "!"are accepted. The empty-input branch returns"!", and the nonempty branch returns"a!". A regression covers this union in either operand of+, checks both input branches and explicit unsupported outcomes, and replays generated witnesses in Node.js.Based on
mainata8c423a75025d8fea0dfba4144d3af9626df2581, after #456 merged. Current head:9493596b599fbe4ce22cf2f3f4edd22f851b824a. The PR contains the concatenation commit and its string-union fix, with three changed files.Local validation on this head with the published pinned JacoDB dependency, without a local substitution: all 5 concatenation tests passed with zero skips/failures/errors, including Node.js replay. The new source-level regression failed on the previous head
ae79f17adb7407aeee5a48b052eaddd24a5b613abecause the empty-input property was missing, then passed with the fix. Detekt main/test passed with zero code smells;git diff --checkpassed. The broader 32-test string validation belongs to the previous rebased headae79f17ad. Local Java 23 and Node.js 26 were used; fresh GitHub CI on the current head is a separate gate.Symbolic Number-to-string conversion, object
ToPrimitive, and genuinely unbacked string references remain unsupported. No merge performed.