Repository navigation
Add debug display as a separate ESM entry point - #200
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
🦋 Changeset detectedLatest commit: 1eab814 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ceyhun-o
approved these changes
Oct 8, 2026
ceyhun-o
left a comment
Contributor
There was a problem hiding this comment.
Looks and works great on Chrome/Safari/Firefox as far as I can see!
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Slotted chrome such as the top control bar receives pointer events across its full width, so it blocked clicks on overlay content like the debug display's Copy and close buttons. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merged
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a debug display: an opt-in overlay panel with live playback diagnostics, for developers and for bug reports. It ships as a separate package entry, so none of it ends up in the main bundle.
New
@theoplayer/web-ui/debugentry (ESM only)src/debug/index.tsand registers<theoplayer-debug-display>,<theoplayer-rolling-chart>and<theoplayer-debug-button>.theoplayer/chromelessand@theoplayer/web-uiitself are external. The debug code imports shared pieces (Button,stateReceiver,Attribute,version) from../index, and a small Rollup plugin (externalizeMainEntry) rewrites that import toimport … from '@theoplayer/web-ui'. This keeps a second copy of the UI runtime and its custom elements out of the debug bundle.getSlottedElementsnow checkslocalName === 'theoplayer-slot-container'instead of importingisSlotContainer. That import pulledSlotContainer(and itscustomElements.define) into the debug bundle.Main UI (generic, no debug-specific code)
UIContainer,DefaultUIandTHEOliveDefaultUIget a newoverlayslot. The overlay layer sits above the chrome and below the menu and error layers, and is hidden while a menu is open.UIContainer.menuOpenedis now publicly readable, andDefaultUIforwards themenu-openedanduser-idleattributes.DefaultUIandTHEOliveDefaultUIget a newoverlay?: ReactNodeprop.Debug display
latency.currentConfiguration), a seekable/buffered timeline, and the time of the last sample.<theoplayer-debug-button>toggles it, witharia-pressedkept in sync.min(480px, 60%)(with a plain480pxfallback for browsers without CSSmin()). On players narrower than 500px it switches to full width through a container query, using the same breakpoint as the menus. Browsers without container queries keep the 60% cap.Usage:
Checks
THEOplayerUI.mjsis 243.6 KB and contains notheoplayer-debug-*.THEOplayerUI.debug.mjsis 34.4 KB.@theoplayer/web-ui/debugin Node.Link to Devin session: https://dolby.devinenterprise.com/sessions/50ad8a122b354986bcfc78390b5a7f00
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/50ad8a122b354986bcfc78390b5a7f00?variant=devin
Requested by: @MattiasBuelens