Repository navigation
Rename debug display changesets to sort by PR - #205
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
| Name | Type |
|---|---|
| @theoplayer/web-ui | Minor |
| @theoplayer/react-ui | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changesets writes changelog entries in the order of the changeset filenames (
readChangesetsusesfs.readdir, which returns them sorted). With the current names, the #200 and #201 entries in the release PR (#203) are interleaved. This PR only renames the files, without changing their content, so that #200's entries come first:@theoplayer/web-ui:debug-1-overlay-slot(Add debug display as a separate ESM entry point #200),debug-2-display(Add debug display as a separate ESM entry point #200),debug-3-ui-version(Add debug display bookmarklet and React debug entry point #201),debug-4-bookmarklet(Add debug display bookmarklet and React debug entry point #201)@theoplayer/react-ui:debug-5-react-overlay-slot(Add debug display as a separate ESM entry point #200),debug-6-react-entry(Add debug display bookmarklet and React debug entry point #201)The
pr: #Noverrides stay as they are, so moving the files doesn't change which PR each entry links to. A localchangeset versionrun gives entries in exactly this order.Link to Devin session: https://dolby.devinenterprise.com/sessions/50ad8a122b354986bcfc78390b5a7f00
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/50ad8a122b354986bcfc78390b5a7f00?variant=devin
Requested by: @MattiasBuelens