Repository navigation
feat: allow slabs, stairs and signs just above crops - #83
Merged
Merged
Conversation
Add planting.low-cover: materials that count as open sky only within max-height blocks above the crop (default 5), so players can build pergolas and lantern posts over fields while caves and buildings still block planting. Entries starting with # are vanilla block tags; double slabs stay a roof. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Dev test (TFMCDev01, this branch's jar at 597f35a, Dev
10/10 as expected. CustomCrops planting and hoe replanting call the same |
XxFran10xX
added a commit
to TF-Minecraft/Docs
that referenced
this pull request
Oct 19, 2026
Covers planting.low-cover (slabs, stairs and signs within max-height blocks of the crop) and block tags in planting material lists, for TF-Minecraft/Cooking#83. Co-authored-by: XxFran10xX <318299142+XxFran10xX@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@coderabbitai full review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Player suggestion (12 ✅ / 0 ❌): let players build signs, slabs and stairs over crops so fields can have pergolas and lantern posts.
Planting already worked under hanging signs, fences and lanterns, but slabs, stairs and standing/wall signs anywhere above the crop counted as a roof. So seeds couldn't be planted under them, and hoe-harvest replanting dropped the seed instead.
This adds
planting.low-covertocrops.yml:low-cover.materialscount as open sky only withinmax-heightblocks above the crop. Higher up, they are a roof as before.#are vanilla block tags (#slabsor#minecraft:slabs).allowed-coverandexempt-vanillaaccept them too. Unknown tags are skipped with a console warning, the same as invalid materials.low-coversection, nothing changes. Existing servers need the section added to theircrops.yml(config files are never rewritten).The same check covers vanilla planting, CustomCrops planting and hoe replanting.
Tests
mvn clean verifypasses locally: 1233 tests, 0 failures, and JaCoCo showsCropPlantingRulewith no missed lines or branches.max-heightis missing;Docs: TF-Minecraft/Docs#304.
🤖 Generated with Claude Code