Skip to content

[review only, do not merge] Cooking #83 low-cover planting - #84

Closed
XxFran10xX wants to merge 1 commit into
review/base-crop-low-coverfrom
review/crop-low-cover
Closed

XxFran10xX wants to merge 1 commit into
review/base-crop-low-coverfrom
review/crop-low-cover

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Review-only copy of #83, which was merged before CodeRabbit had reviewed it (CodeRabbit won't review closed PRs). The base is main before #83 (afd9364) and the head is the merged commit 728599e, so the diff is exactly #83. Findings get fixed in a new PR against main. This PR will be closed unmerged and both branches deleted.

@coderabbitai full review

🤖 Generated with Claude Code

* feat: allow slabs, stairs and signs just above crops

Add planting.low-cover: materials that count as open sky only within
max-height blocks above the crop (default 5), so players can build
pergolas and lantern posts over fields while caves and buildings still
block planting. Entries starting with # are vanilla block tags; double
slabs stay a roof.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: mention low pergolas over crops in README

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: XxFran10xX <318299142+XxFran10xX@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63431591-9c83-4393-96e5-52d0286503d6
📥 Commits

Reviewing files that changed from the base of the PR and between afd9364 and 728599e.

📒 Files selected for processing: 4
  • README.md
  • src/main/java/net/tfminecraft/cooking/crops/CropPlantingRule.java
  • src/main/resources/crops.yml
  • src/test/java/net/tfminecraft/cooking/crops/CropPlantingTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Crops can now grow beneath configured low decorations, including slabs, stairs and signs, up to five blocks above them.
    • Block tags can be used to configure permitted cover materials.
  • Documentation
    • Clarified that double slabs count as full-block roofs.

Crop planting rules now support configurable low-cover materials and height limits. Block materials and block tags can define low cover. The sky check treats qualifying cover as open sky, except double slabs.

Changes: Crop Low-Cover Rules

Layer / File(s) Summary
Configure low-cover materials
src/main/java/net/tfminecraft/cooking/crops/CropPlantingRule.java, src/test/java/net/tfminecraft/cooking/crops/CropPlantingTest.java
The rule reads low-cover materials and a non-negative height limit. It accepts block materials and block tags, and logs invalid entries. Tests cover tag expansion and invalid entries.
Apply low-cover rules to sky checks
src/main/java/net/tfminecraft/cooking/crops/CropPlantingRule.java, src/main/resources/crops.yml, src/test/java/net/tfminecraft/cooking/crops/CropPlantingTest.java, README.md
The sky check allows configured low cover within the height limit, but double slabs remain roofs. The configuration permits slab, stair and sign tags up to five blocks above crops. Tests check height limits and slab behaviour. The README now includes low pergolas in its crop-growing description.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 72859

No actionable code issue was identified. This review-only PR is intended to close unmerged.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX

Copy link
Copy Markdown
Contributor Author

CodeRabbit approved with no actionable comments. Closing unmerged as planned; the change shipped in v0.5.4.

@XxFran10xX XxFran10xX closed this Oct 19, 2026
@XxFran10xX
XxFran10xX deleted the review/crop-low-cover branch October 19, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant