Repository navigation
Fix header overflow when a phone rotates to landscape - #711
Merged
Merged
Conversation
Between 640px and 1279px the header was wider than the screen, so iOS shrank the page and left a blank area on the right. Hide the tagline and the command palette button below xl, and the price and GitHub labels below md. Thanks, Gerard
Gemini PR ReviewReviewed commit: No actionable findings. |
axe-core 4.14 reports the dimmed rows as low contrast, which fails the accessibility test on every browser. Unlit rows now start fully transparent and fade in as before. Thanks, Gerard
Gemini PR ReviewReviewed commit: There are no actionable findings in the provided diff based on the stated criteria. The changes are purely cosmetic, adjusting CSS properties and responsiveness classes within an HTML file. They do not introduce security vulnerabilities, correctness bugs, performance issues, or require new tests for functionality in a Go or Java codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotating a phone to landscape made the page shrink and leave a blank area on the right. The header was about 100px wider than the screen between 640px and 1279px, and iOS scales the page down to fit.
Below xl the header now drops the tagline and the command palette button (search is still in the menu). Below md it drops the price and GitHub labels. The icons and links stay.
Checked nine viewport sizes from 568x320 to 1279x800 in WebKit and Chromium. 664 and 667 wide overflowed before, none do now. Not tested on a real iPhone.
Thanks,
Gerard