Repository navigation
Stop the header overflowing at 440px and on the Arena page - #712
Merged
Merged
Conversation
The first fix covered 640 to 1279px on the homepage. A Pro Max phone in portrait is 440px wide, where the WASM demo badge appeared and pushed the header 19px past the screen, so iOS kept that width after rotating. The badge now waits for 500px. The Arena header had the same problem from 640 to 756px, so its labels and the command palette button move to wider breakpoints. A test now checks both pages for sideways scroll at 13 widths. Thanks, Gerard
Gemini PR ReviewReviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landscape fix in #711 covered 640 to 1279px on the homepage and missed two cases.
A Pro Max phone in portrait is 440px wide. The WASM demo badge showed from 440px and pushed the header 19px past the screen, so iOS kept that narrow layout after rotating to landscape. The badge now waits for 500px.
The Arena header overflowed from 640 to 756px, which is a phone in landscape. Its Copilot and GitHub labels and the command palette button now show at wider breakpoints.
Added a test that loads the homepage and Arena at 13 widths from 360 to 1180 and fails on any sideways scroll. It fails on the old code and passes now. I swept every width from 320 to 1300 in WebKit. Arena still overflows at 1700px and wider (large desktop monitors), which I left alone. Not tested on a real iPhone.
Thanks,
Gerard