Repository navigation
Fix mobile header overflow caused by the Get Pro button - #619
Merged
Merged
Conversation
The header controls were 24px wider than the viewport on phones, which pushed the hamburger off screen and failed the mobile E2E jobs. Tighten spacing and padding below the sm breakpoint. Thanks, Gerard Recinto
Gemini PR ReviewReviewed commit: There are no actionable findings in the provided diff. The changes are purely cosmetic adjustments to Tailwind CSS utility classes within an HTML file, related to spacing and padding, and do not introduce any security, correctness, or testing issues based on the criteria. |
Thanks, Gerard Recinto
Gemini PR ReviewReviewed commit: No actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Get Pro button added in #616 made the mobile header 24px wider than the viewport, which pushed the hamburger off screen. This tightens spacing and padding below the sm breakpoint.
Verified locally: mobile-chrome and mobile-safari pass for 'page does not scroll sideways' and 'Mobile Nav Menu'. These were the two failing mobile E2E tests on #617 and #618.
Thanks,
Gerard Recinto